Transmit the prefetch list to snapshotter during runp pod.yaml #493

billie60 · 2023-06-15T18:01:56Z

Hello, in this PR, I start an NRI plugin and subscribe to pod creation event. The plugin invokes the RunPodSandbox method to obtain prefetch list file path recorded in pod.yaml when monitoring the pod creation command. Then send the prefetch list file path to snapshotter through the specified socket API. After receiving prefetch list file path, snapshotter will save the content and add --prefetch-files parameter when building nydusd command to customize prefetch files content. I will submit the modifications to snapshotter in the next PR.

imeoer · 2023-06-16T01:45:53Z

cc @sctb512 @changweige

imeoer · 2023-06-16T01:46:51Z

@billie60 It seems to have a broken build CI https://github.com/containerd/nydus-snapshotter/actions/runs/5282088960/jobs/9556557174?pr=493

sctb512 · 2023-06-16T02:23:10Z

cmd/prefetchfiles-nri-plugin/main.go

+}
+
+func sendDataOverHTTP(data string, endpoint string) error {
+	url := "http://172.0.0.1:9110" + endpoint


Should we POST a request to "http://172.0.0.1:9110"? This HTTP URL is used to export metrics and may not always be enabled, so we can not be fully dependent on it. I think the unix domain socket for the system controller is more reasonable.

sctb512 · 2023-06-16T02:24:04Z

cmd/prefetchfiles-nri-plugin/main.go

+type PluginConfig struct {
+	Events     []string `toml:"events"`
+	ServerPath string   `toml:"server_path"`
+	PersistDir string   `toml:"persist_dir"`


It appears that this entry is not used in your nri plugin.

Removed it in commits fd34

sctb512 · 2023-06-16T02:25:20Z

cmd/prefetchfiles-nri-plugin/main.go

+		return err
+	}
+
+	conn, err := net.Dial("unix", "/run/containerd-nydus/system.sock")


It is better to set the unix domain socket path from a configuration entry.

Set sockaddr as a command parameter in fd34

cmd/prefetchfiles-nri-plugin/main.go

sctb512 · 2023-06-16T02:33:55Z

cmd/prefetchfiles-nri-plugin/main.go

+}
+
+func (p *plugin) onClose() {
+	for _, fanotifyServer := range globalFanotifyServer {


The fanotifyServer is not used by this NRI plugin, please remove it.

Removed fanotifyServer

cmd/prefetchfiles-nri-plugin/main.go

sctb512 · 2023-06-16T02:43:17Z

cmd/prefetchfiles-nri-plugin/main.go

+type PluginArgs struct {
+	PluginName   string
+	PluginIdx    string
+	PluginEvents string


If you only need to use RunPodSandbox interface, you can remove this configuration entry and define it as a constant.

In order to improve the flexibility of prefetch files transmit, it may be necessary to increase the monitoring of the Create Container event, so I have temporarily kept this part. If any modifications are needed, I will make them the next time I update the PR.

Only some specific events can catch the container image name & prefetch list, why do we still need to export the arg?

cmd/prefetchfiles-nri-plugin/main.go

imeoer · 2023-06-20T01:59:38Z

cmd/prefetchfiles-nri-plugin/main.go

+	"bytes"
+	"context"
+	"fmt"
+	"github.com/containerd/nydus-snapshotter/pkg/errdefs"


The external package should be moved to the bottom.

imeoer · 2023-06-20T02:05:45Z

cmd/prefetchfiles-nri-plugin/main.go

+const (
+	defaultEvents     = "RunPodSandbox"
+	defaultServerPath = "/usr/local/bin/optimizer-server"
+	defaultPersistDir = "/opt/nri/optimizer/results"


Please remove some irrelevant codes.

imeoer · 2023-06-20T02:06:48Z

cmd/prefetchfiles-nri-plugin/main.go

+)
+
+const (
+	endpointPL      = "/api/v1/daemons/prefetch" //////////todo


TODO: what's todo.

endpointPrefetch

imeoer · 2023-06-20T02:08:29Z

cmd/prefetchfiles-nri-plugin/main.go

+	endpointPL      = "/api/v1/daemons/prefetch" //////////todo
+	defaultEvents   = "RunPodSandbox"
+	defaulthttp     = "http://system.sock"
+	defaultsockaddr = "/run/containerd-nydus/system.sock"


defaultSockAddr

imeoer · 2023-06-20T02:12:08Z

cmd/prefetchfiles-nri-plugin/main.go

+type PluginArgs struct {
+	PluginName   string
+	PluginIdx    string
+	PluginEvents string


Only some specific events can catch the container image name & prefetch list, why do we still need to export the arg?

imeoer · 2023-06-20T02:17:39Z

cmd/prefetchfiles-nri-plugin/main.go

+	logWriter  *syslog.Writer
+)
+
+func sendDataOverHTTP(data string, endpoint string, sock string) error {


data, endpoint, sock string

imeoer · 2023-06-20T02:19:10Z

cmd/prefetchfiles-nri-plugin/main.go

+	client := &http.Client{
+		Transport: &http.Transport{
+			DialContext: func(_ context.Context, _, _ string) (net.Conn, error) {
+				return conn, nil


Should put return net.Dial("unix", sock) in here?

imeoer · 2023-06-20T02:20:37Z

cmd/prefetchfiles-nri-plugin/main.go

+
+func (p *plugin) RunPodSandbox(pod *api.PodSandbox) error {
+	name := pod.Name
+	parts := strings.Split(name, "-")


Why split the name here?

In pod.yaml, the name is defined as image_name-sandbox, splitting the name is to obtain the image_ name. And if the PrefetchList in the States structure needs to be defined as a dictionary in subsequent modifications, image_ name can be used as a key in the dictionary.

imeoer · 2023-06-20T02:22:06Z

cmd/prefetchfiles-nri-plugin/main.go

+	name = parts[0]
+	if pod.Annotations == nil {
+		log.Printf("error: Pod annotations is nil")
+		return errors.New("Pod annotations is nil")


The error message should start with a lowercase letter.

imeoer · 2023-06-20T02:23:13Z

cmd/prefetchfiles-nri-plugin/main.go

+
+			err = p.stub.Run(context.Background())
+			if err != nil {
+				log.Errorf("plugin exited with error %v", err)


return errors.Wrap(err, "plugin exited")

codecov · 2023-06-20T09:21:09Z

Codecov Report

Merging #493 (a33ce0b) into main (a6f4457) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

❗ Current head a33ce0b differs from pull request most recent head eebcc0f. Consider uploading reports for the commit eebcc0f to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   37.81%   37.70%   -0.12%     
==========================================
  Files          60       60              
  Lines        7090     7116      +26     
==========================================
+ Hits         2681     2683       +2     
- Misses       4097     4121      +24     
  Partials      312      312

Files Changed	Coverage Δ
config/global.go	`31.64% <ø> (ø)`
pkg/daemon/command/command.go	`56.88% <0.00%> (-2.17%)`	⬇️
pkg/daemon/config.go	`0.00% <0.00%> (ø)`
pkg/daemon/daemon.go	`0.00% <ø> (ø)`
pkg/manager/daemon_adaptor.go	`0.00% <0.00%> (ø)`
pkg/system/system.go	`5.48% <0.00%> (-0.30%)`	⬇️

... and 2 files with indirect coverage changes

sctb512 · 2023-06-20T11:22:28Z

cmd/prefetchfiles-nri-plugin/main.go

+}
+
+var (
+	globalsock string


globalsock -> globalSocket

sctb512 · 2023-06-20T11:23:03Z

cmd/prefetchfiles-nri-plugin/main.go

+	endpointPrefetch = "/api/v1/daemons/prefetch"
+	defaultEvents    = "RunPodSandbox"
+	defaultHTTPURL   = "http://system.sock"
+	defaultSockaddr  = "/run/containerd-nydus/system.sock"


defaultSystemControllerAddress, refer to https://github.com/containerd/nydus-snapshotter/blob/v0.9.0/internal/constant/values.go#L38

sctb512 · 2023-06-20T11:30:02Z

cmd/prefetchfiles-nri-plugin/main.go

+const (
+	endpointPrefetch = "/api/v1/daemons/prefetch"
+	defaultEvents    = "RunPodSandbox"
+	defaultHTTPURL   = "http://system.sock"


Please refer to the implementation that nydus-snapshotter dials nydusd through an unix domain socket. https://github.com/containerd/nydus-snapshotter/blob/v0.9.0/pkg/daemon/client.go#L90

sctb512 · 2023-06-20T11:32:55Z

cmd/prefetchfiles-nri-plugin/main.go

+
+func sendDataOverHTTP(data, endpoint, sock string) error {
+	url := defaultHTTPURL + endpoint
+	req, err := http.NewRequest("POST", url, bytes.NewBufferString(data))


Why use POST method. Morever we can use a constant http.MethodGet instead of "GET".
Please refer to https://github.com/containerd/nydus-snapshotter/blob/v0.9.0/pkg/daemon/client.go#L284

cmd/prefetchfiles-nri-plugin/main.go

sctb512 · 2023-06-20T11:52:42Z

cmd/prefetchfiles-nri-plugin/main.go

+				err  error
+			)
+
+			flags.Args.Sockaddr = c.String("sockaddr")


This line is redundant.

sctb512 · 2023-06-20T11:53:59Z

cmd/prefetchfiles-nri-plugin/main.go

+			log.SetFormatter(&logrus.TextFormatter{
+				PadLevelText: true,
+			})
+			logWriter, err = syslog.New(syslog.LOG_INFO, "prefetchfiles-nri-plugin")


sctb512 · 2023-06-20T11:54:31Z

cmd/prefetchfiles-nri-plugin/main.go

+type PluginArgs struct {
+	PluginName string
+	PluginIdx  string
+	Sockaddr   string


SocketAddress or Address?

sctb512 · 2023-06-20T11:56:54Z

cmd/prefetchfiles-nri-plugin/main.go

+			Destination: &args.PluginIdx,
+		},
+		&cli.StringFlag{
+			Name:        "sockaddr",


Please use - to split two words for command arguments. Just like socket-addr.

sctb512 · 2023-06-20T12:04:58Z

cmd/prefetchfiles-nri-plugin/main.go

+
+			p := &plugin{}
+
+			Events := defaultEvents


This line is redundant.

changweige

Thanks but we still need more work

changweige · 2023-06-29T01:45:04Z

cmd/prefetchfiles-nri-plugin/main.go

+)
+
+const (
+	endpointPrefetch               = "/api/v1/daemons/prefetch"


How about replacing the service endpoint with /api/v1/prefetch since it's possible no nydusd daemon is running while nydus-snapshotter is preparing snapshots

changweige · 2023-06-29T01:49:19Z

pkg/globalvar/globalvar.go

@@ -0,0 +1,10 @@
+package globalvar
+
+// var PldataDict = make(map[string]string)


Please avoid dead code

changweige · 2023-06-29T01:51:20Z

pkg/daemon/daemon.go

@@ -53,6 +53,7 @@ type States struct {
 	// Where the configuration file resides, all rafs instances share the same configuration template
 	ConfigDir      string
 	SupervisorPath string
+	PrefetchFiles  string


Data in States field will all be persisted in the DB, is it necessary to store the PrefetchFiles into DB?

Hello, thanks for your review. According to my understanding, adding PrefetchFiles to States is to persist this parameter. If PrefetchFiles is not added to States, when snapshotter unexpectedly restarts and triggers the recovery process after running the nydusd command, the BuildDaemonCommand method will discard the --prefetch-files parameter when rebuilding the nydusd command.

Is this resolved? I suppose it's not. You CAN'T put the prefetch info into DB definitely. I am a little tired of such things

I also think that saving the PrefetchFiles to DB is not a good choice. You can move it to Rafs struct if this value is different to each instance. If we need to store it in the DB, please provide more details. TKS.

I am sooo sorry that many of my previous replies to comments were in a pending state, so that you cannot see them. I will reply again, I'm really really sorry.

changweige · 2023-06-29T02:05:35Z

cmd/prefetchfiles-nri-plugin/main.go

+	if !ok {
+		errMsg := "pod.yaml annotations don't have prefetch list."
+		log.Printf("error: %s", errMsg)
+		return errors.New(errMsg)


We should not return error as it's possible that no prefetch list is ever specified the user

changweige · 2023-06-29T02:07:41Z

cmd/prefetchfiles-nri-plugin/main.go

+		return errors.New("pod annotations is nil")
+	}
+
+	prefetchList, ok := pod.Annotations["prefetch_list"]


I am worrying if the prefetch_list matches K8s annotation nameing requirement. It should have a name space. Or is it possible to configure the annotation name since different cloud vendors may have different namespaces

changweige · 2023-06-29T02:09:15Z

cmd/prefetchfiles-nri-plugin/main.go

+		log.Printf("failed to send data: %v\n", err)
+		return err
+	}
+	log.Println("Data sent successfully")


Please don't print tons of normal message to system log

Please remove this message.

changweige · 2023-06-29T02:12:11Z

pkg/system/system.go

@@ -167,8 +170,19 @@ func (sc *Controller) registerRouter() {
 	sc.router.HandleFunc(endpointDaemons, sc.describeDaemons()).Methods(http.MethodGet)
 	sc.router.HandleFunc(endpointDaemonsUpgrade, sc.upgradeDaemons()).Methods(http.MethodPut)
 	sc.router.HandleFunc(endpointDaemonRecords, sc.getDaemonRecords()).Methods(http.MethodGet)
+	sc.router.HandleFunc(endpointPrefetch, sc.getPrefetchFiles()).Methods(http.MethodGet)


Http Get method should be used when client wants to query nydus-snapshotter's states. I am suggesting using Put method here

changweige · 2023-06-29T02:12:51Z

pkg/system/system.go

@@ -167,8 +170,19 @@ func (sc *Controller) registerRouter() {
 	sc.router.HandleFunc(endpointDaemons, sc.describeDaemons()).Methods(http.MethodGet)
 	sc.router.HandleFunc(endpointDaemonsUpgrade, sc.upgradeDaemons()).Methods(http.MethodPut)
 	sc.router.HandleFunc(endpointDaemonRecords, sc.getDaemonRecords()).Methods(http.MethodGet)
+	sc.router.HandleFunc(endpointPrefetch, sc.getPrefetchFiles()).Methods(http.MethodGet)
+}
+func (sc *Controller) getPrefetchFiles() func(w http.ResponseWriter, r *http.Request) {


rename it setPrefetchFiles ?

changweige · 2023-06-29T02:13:54Z

pkg/system/system.go

+func (sc *Controller) getPrefetchFiles() func(w http.ResponseWriter, r *http.Request) {
+	return func(w http.ResponseWriter, r *http.Request) {
+		body, _ := io.ReadAll(r.Body)
+		err := json.Unmarshal(body, &globalvar.Msg)


Deserializing the body to a global variable is not safe. We need to reconsider how to manage the prefetch files list

Hello, other comments have been modified. However, this comment has been tried many ways but no better solution has been found. May I ask if you have any specific suggestions so that I can improve this part of the code again? Thank you very much.

changweige · 2023-06-29T02:14:20Z

pkg/system/system.go

+}
+func (sc *Controller) getPrefetchFiles() func(w http.ResponseWriter, r *http.Request) {
+	return func(w http.ResponseWriter, r *http.Request) {
+		body, _ := io.ReadAll(r.Body)


Please don't ignore any retured error

sctb512 · 2023-07-07T13:48:00Z

cmd/prefetchfiles-nri-plugin/main.go

+		return err
+	}
+
+	req, err := http.NewRequest(http.MethodPut, url, bytes.NewBuffer(body)) // todo 改为put


Please remove unnecessary comments.

sctb512 · 2023-07-07T13:49:48Z

cmd/prefetchfiles-nri-plugin/main.go

+		return err
+	}
+	if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("failed to GET request with code %d", resp.StatusCode)


"failed to send data, status code: %d"

sctb512 · 2023-07-07T13:55:51Z

cmd/prefetchfiles-nri-plugin/main.go

+		return nil
+	}
+
+	prefetchList, ok := pod.Annotations["containerd.io/snapshotter/nydus-prefetch-list"]


How about "containerd.io/snapshot/nydus-prefetch"? In addition, this value should be assigned to a constant.

sctb512 · 2023-07-07T13:58:48Z

cmd/prefetchfiles-nri-plugin/main.go

+	prefetchList, ok := pod.Annotations["containerd.io/snapshotter/nydus-prefetch-list"]
+	if !ok {
+		errMsg := "pod.yaml annotations don't have prefetch list."
+		log.Warnf("error: %s", errMsg)


There is no need to use a variable to hold errMsg. Moreover, error: is confused.

I think this message is surplus.

sctb512 · 2023-07-07T13:59:40Z

cmd/prefetchfiles-nri-plugin/main.go

+		log.Printf("failed to send data: %v\n", err)
+		return err
+	}
+	log.Println("Data sent successfully")


Please remove this message.

sctb512 · 2023-07-07T14:08:05Z

pkg/globalvar/globalvar.go

+package globalvar
+
+type Message struct {
+	Name          string `json:"name"`


Is this the image name? I think it is not enough to identify a unique image.

sctb512 · 2023-07-07T14:11:57Z

pkg/globalvar/globalvar.go

+
+type Message struct {
+	Name          string `json:"name"`
+	PrefetchFiles string `json:"prefetchList"`


Please make sure the variables express the same meaning. In addition, we often use underscore naming convention for json data.

sctb512 · 2023-07-07T14:18:21Z

pkg/system/system.go

+			return
+		}
+
+		log.L.Infof("received msg from RunPodSandbox event: %v ", filesystem.PrefetchMsg)


received prefetch list from nri plugin: %v

sctb512 · 2023-07-07T14:22:29Z

pkg/system/system.go

+		body, err := io.ReadAll(r.Body)
+		if err != nil {
+			log.L.Errorf("Failed to read prefetch list: %v", err)
+			http.Error(w, "Failed to read prefetch list", http.StatusInternalServerError)


Should we return this error to client?

sctb512 · 2023-07-07T14:32:13Z

pkg/filesystem/fs.go

@@ -45,6 +46,8 @@ const (
 	DummyMountpoint     string = "/dummy"
 )

+var PrefetchMsg globalvar.Message


This can be replaced by lru.Cache. Moreover, we should consider whether global variables should be used.

cmd/prefetchfiles-nri-plugin/main.go

sctb512 · 2023-07-11T14:58:09Z

config/global.go

+	if err := json.Unmarshal(body, &prefetchMsg); err != nil {
+		return err
+	}
+	globalConfig.PrefetchFiles = prefetchMsg


This is not safe, I suggest to use a map to store this message and use a lock before modifying it.

And delete it by key registry/repo/name:tag when starting nydusd successfully.

sctb512 · 2023-07-11T15:05:03Z

pkg/system/system.go

+			log.L.Errorf("Failed to read prefetch list: %v", err)
+			return
+		}
+		if err = config.SetPrefetchFiles(Msg, body); err != nil {


It seems the Msg transmitted to SetPrefetchFiles is redundant.

sctb512 · 2023-07-11T15:37:21Z

Also, please make sure that this plugin doesn't hang for too long if sending data fails, which will result in a context deadline exceeded error for containerd.

Others, LGTM. cc @changweige @imeoer

Thanks for @billie60's great work making nydus snapshotter more flexible to use prefetch list in k8s scenario. I'd like to move this forward.

changweige

Could you help add an e2e test for the plugin?

changweige · 2023-07-12T11:24:24Z

config/global.go

+	PrefetchFiles    PrefetchMessage
+}
+type PrefetchMessage struct {
+	ImageAddress  string `json:"image_address"`


Can we rename image_address to image_reference which means it format of REPOSITORY:TAG

changweige · 2023-07-12T11:30:20Z

cmd/prefetchfiles-nri-plugin/main.go

+	defaultEvents                  = "RunPodSandbox"
+	defaultSystemControllerAddress = "/run/containerd-nydus/system.sock"
+	nydusPrefetchAnnotation        = "containerd.io/snapshot/nydus-prefetch"
+	imageAddressAnnotation         = "containerd.io/snapshot/nydus-image-address"


Can this annotation be passed by k8s ? https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations/
There are too many slashes?

Also please rename it to nydus-image or nydus-image-reference

changweige · 2023-07-13T02:08:44Z

config/global.go

@@ -37,6 +39,15 @@ type GlobalConfig struct {
 	DaemonThreadsNum int
 	CacheGCPeriod    time.Duration
 	MirrorsConfig    MirrorsConfig
+	PrefetchFiles    PrefetchMessage


This is not the right place for storing prefetch information. The struct GlobalConfig is only for storing configuration items from CLI and toml configuration file

changweige · 2023-07-13T02:09:18Z

config/global.go

+	if err := json.Unmarshal(body, &prefetchMsg); err != nil {
+		return err
+	}
+	globalConfig.PrefetchFiles = prefetchMsg


Moreover, it's not concurrency-safe.

changweige · 2023-07-13T02:20:00Z

Please refine the commit name. At least, remove the WIP prefix

imeoer · 2023-07-31T02:43:20Z

cc @changweige PATL again, thanks!

changweige · 2023-08-02T11:19:14Z

Is the commit Merge branch 'main' into prefetchfiles-nri purposed carried on this PR ? Could you squash or fix it?

sctb512 · 2023-08-13T13:04:58Z

cmd/prefetchfiles-nri-plugin/main.go

+
+			log = logrus.StandardLogger()
+
+			viper.SetConfigName("prefetchConfig")


Do we need to import the viper package?

sctb512 · 2023-08-13T13:13:31Z

pkg/prefetch/prefetch.go

+)
+
+var (
+	prefetchMsg MessagePrefetch


I'm not sure, but I think this global variable may cause some inconsistencies. For instance, if two pods are started, the first one needs to pull a larger image than the second one. Can they get the correct prefetch files? Do you have a test for this case?

sctb512 · 2023-08-13T13:15:33Z

pkg/daemon/daemon.go

@@ -53,6 +53,7 @@ type States struct {
 	// Where the configuration file resides, all rafs instances share the same configuration template
 	ConfigDir      string
 	SupervisorPath string
+	PrefetchFiles  string


I also think that saving the PrefetchFiles to DB is not a good choice. You can move it to Rafs struct if this value is different to each instance. If we need to store it in the DB, please provide more details. TKS.

changweige

Otherwise, looks good

pkg/prefetch/prefetch.go

changweige · 2023-08-24T06:01:27Z

pkg/manager/daemon_adaptor.go

@@ -160,6 +165,17 @@ func (m *Manager) BuildDaemonCommand(d *daemon.Daemon, bin string, upgrade bool)
 			command.WithID(d.ID()))
 	}

+	prefetchMap := prefetch.GetPrefetchMap()
+	if imageReference != "" {
+		prefetchfiles, ok := prefetchMap[imageReference]


Accessing prefetchMap should be locked.

fixed， I have add a lock in GetPrefetchMap and copy value in it.

changweige · 2023-08-24T06:13:20Z

cmd/prefetchfiles-nri-plugin/main.go

+
+	err := sendDataOverHTTP(prefetchList, endpointPrefetch, globalSocket)
+	if err != nil {
+		log.Errorf("failed to send data: %v\n", err)


No need to append \n

changweige · 2023-08-24T06:14:38Z

cmd/prefetchfiles-nri-plugin/main.go

+			log = logrus.StandardLogger()
+
+			configFileName := "prefetchConfig.toml"
+			configPath := "."


Do you man configDir? configPath looks like a path to the config file

Though current dir . looks strange. If NRI plugin process' current dir has the config file, it is not necessary to have it prefix

changweige · 2023-08-24T06:18:35Z

cmd/prefetchfiles-nri-plugin/main.go

+			if err != nil {
+				log.Warnf("failed to read config file: %v", err)
+			}
+			if configSocketAddr := config.Get("file_prefetch.socket_address").(string); configSocketAddr != "" {


Type assertion may fail, please handl it

cmd/prefetchfiles-nri-plugin/prefetchConfig.toml

pkg/manager/daemon_adaptor.go

changweige · 2023-08-24T06:29:39Z

Can we have a doc to describe how to deploy the NRI plugin and an associated e2e test would be greater

cmd/prefetchfiles-nri-plugin/main.go

pkg/prefetch/prefetch.go

1. modify config file's default dir in /etc/nydus/ 2. modify GetPrefetchMap in prefetch package to GetPrefetchInfo

changweige

LGTM~ Thanks for your contribution! 👍

changweige · 2023-08-28T10:50:42Z

Hopefully, we can have following PRs:

Add related documents
Define a Makefile target to build the plugin in the CI job
Add e2e test

sctb512 reviewed Jun 16, 2023

View reviewed changes

cmd/prefetchfiles-nri-plugin/main.go Outdated Show resolved Hide resolved

sctb512 reviewed Jun 16, 2023

View reviewed changes

cmd/prefetchfiles-nri-plugin/main.go Outdated Show resolved Hide resolved

billie60 force-pushed the prefetchfiles-nri branch from 781e6e6 to fd34ce9 Compare June 18, 2023 10:56

sctb512 mentioned this pull request Jun 19, 2023

Prefetchfiles snapshotter #496

Closed

imeoer reviewed Jun 20, 2023

View reviewed changes

billie60 force-pushed the prefetchfiles-nri branch 4 times, most recently from 9168fc0 to 03307c5 Compare June 20, 2023 11:13

sctb512 reviewed Jun 20, 2023

View reviewed changes

billie60 force-pushed the prefetchfiles-nri branch 4 times, most recently from aae793e to c146069 Compare June 28, 2023 16:22

changweige requested changes Jun 29, 2023

View reviewed changes

billie60 force-pushed the prefetchfiles-nri branch 2 times, most recently from 758ab42 to 6dac99b Compare July 6, 2023 12:03

sctb512 reviewed Jul 7, 2023

View reviewed changes

billie60 force-pushed the prefetchfiles-nri branch 4 times, most recently from c22f52c to 2b1e837 Compare July 11, 2023 01:21

sctb512 reviewed Jul 11, 2023

View reviewed changes

changweige reviewed Jul 13, 2023

View reviewed changes

billie60 force-pushed the prefetchfiles-nri branch 5 times, most recently from 38f109b to 27aee64 Compare July 27, 2023 06:11

billie60 force-pushed the prefetchfiles-nri branch 2 times, most recently from 038fb4b to eebcc0f Compare August 7, 2023 16:09

sctb512 reviewed Aug 13, 2023

View reviewed changes

billie60 force-pushed the prefetchfiles-nri branch 3 times, most recently from 06c3bcd to e8ad73c Compare August 21, 2023 05:25

changweige reviewed Aug 24, 2023

View reviewed changes

billie60 force-pushed the prefetchfiles-nri branch 2 times, most recently from a4792cf to 7584fee Compare August 25, 2023 04:15

changweige reviewed Aug 28, 2023

View reviewed changes

cmd/prefetchfiles-nri-plugin/main.go Outdated Show resolved Hide resolved

pkg/prefetch/prefetch.go Outdated Show resolved Hide resolved

nri-plugin: file prefetching

983f342

1. modify config file's default dir in /etc/nydus/ 2. modify GetPrefetchMap in prefetch package to GetPrefetchInfo

billie60 force-pushed the prefetchfiles-nri branch from 7584fee to 983f342 Compare August 28, 2023 09:59

changweige approved these changes Aug 28, 2023

View reviewed changes

changweige merged commit 490cc94 into containerd:main Aug 28, 2023
16 checks passed

sctb512 mentioned this pull request Dec 29, 2023

[backport v0.9] Transmit the prefetch list to snapshotter during runp pod.yaml #571

Merged

		@@ -0,0 +1,10 @@
		package globalvar

		// var PldataDict = make(map[string]string)


		log = logrus.StandardLogger()

		viper.SetConfigName("prefetchConfig")

Transmit the prefetch list to snapshotter during runp pod.yaml #493

Transmit the prefetch list to snapshotter during runp pod.yaml #493

Conversation

billie60 commented Jun 15, 2023

imeoer commented Jun 16, 2023

imeoer commented Jun 16, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 20, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sctb512 Jun 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sctb512 Jun 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changweige left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changweige Jul 13, 2023 • edited Loading

Choose a reason for hiding this comment

sctb512 Aug 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changweige Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

changweige Jun 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sctb512 Jul 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sctb512 commented Jul 11, 2023

changweige left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 20, 2023 •

edited

Loading

sctb512 Jun 20, 2023 •

edited

Loading

sctb512 Jun 20, 2023 •

edited

Loading

changweige Jul 13, 2023 •

edited

Loading

sctb512 Aug 13, 2023 •

edited

Loading

changweige Jun 29, 2023 •

edited

Loading

changweige Jun 29, 2023 •

edited

Loading

sctb512 Jul 7, 2023 •

edited

Loading