Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Ci adjustments & cleanups #3739

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Dec 7, 2024

Minor CI cleanup prepping for landing of custom test images for windows in a subsequent PR.

  • suggesting we stop using explicit version for well-known actions, and use major versions instead
  • removing parameters that are actually default values

@apostasie apostasie marked this pull request as ready for review December 8, 2024 08:30
@AkihiroSuda AkihiroSuda modified the milestone: v2.0.2 Dec 8, 2024
@apostasie
Copy link
Contributor Author

Not sure what is going on with #3719 (and variants).
Maybe these tests are somehow broken.

Will look into it as it becomes more aggravating.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants