Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark nerdctl builder debug as incompatible with Docker #3655

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 7, 2024

Close #3652

The command line syntax is different across nerdctl builder debug and docker buildx debug (w/ BUILDX_EXPERIMENTAL=1)

@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Nov 7, 2024
@AkihiroSuda AkihiroSuda added this to the v2.0.1 (tentative) milestone Nov 7, 2024
@AkihiroSuda
Copy link
Member Author

        Command:  /usr/bin/docker builder debug /tmp/TestBuilderDebug3887067063/001
        ExitCode: 1
        Error:    exit status 1
        Stdout:   
        Stderr:   ERROR: unknown command "/tmp/TestBuilderDebug3887067063/001" for "docker buildx debug"

@AkihiroSuda
Copy link
Member Author

cc @ktock Was the CLI convention changed in buildx?

Close issue 3652

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda changed the title CI: fix "docker builder debug not recognized as a command" Mark nerdctl builder debug as incompatible with Docker Nov 7, 2024
@ktock
Copy link
Member

ktock commented Nov 7, 2024

docker buildx debug and nerdctl builder debug have different syntax each other and the compatibility isn't guaranteed yet.

@ktock
Copy link
Member

ktock commented Nov 7, 2024

FAIL cmd/nerdctl/container.TestCreate/logs (0.02s)

Error on CI seems unrelated to the chanage. Rerunning it.

@AkihiroSuda AkihiroSuda merged commit 561334f into containerd:main Nov 7, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI BROKEN] [URGENT] Integration test broken for docker
2 participants