[WIP] Test rework permanent next-target #3517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
finally-disable-retries
branch
7 times, most recently
from
20b08e0
to
521d09a
Compare
apostasie
commented
Oct 8, 2024
.github/workflows/test.yml
Outdated
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 20 | ||
| lint-go: | ||
| timeout-minutes: "${{ fromJSON(env.SHORT_TIMEOUT) }}" |
There was a problem hiding this comment.
Whoever came-up with this notion that it would be cool to have the world CIs built on top of yaml + shell + a layer of crap deserves to be repeatedly whacked with a wet trout.
apostasie
force-pushed
the
finally-disable-retries
branch
18 times, most recently
from
cd2c625
to
b6022fc
Compare
apostasie
changed the title
|
@AkihiroSuda technically ready for review, although we should first merge the "global lock for CNI", along with "part 4" - then I will rebase and break it in cleaner commits. |
apostasie
force-pushed
the
finally-disable-retries
branch
3 times, most recently
from
ab11cef
to
9be06cf
Compare
apostasie
force-pushed
the
finally-disable-retries
branch
3 times, most recently
from
1c16e3b
to
161dc04
Compare
apostasie
changed the title
apostasie
force-pushed
the
finally-disable-retries
branch
9 times, most recently
from
ece4022
to
1fd7aae
Compare
apostasie
changed the title
Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
finally-disable-retries
branch
from
1fd7aae
to
4cb201b
Compare
|
Has been fully subsumed into breakout PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
This PR is a dump of all next- things for test rework.
It will never be merged, and will be forked-out into smaller PR.
Github actions changes:
Integration test entrypoint:
./hack/test-integration.shDockerfile changes:
Currently, test suites have been ran locally (no-flaky, on the host directly) 100 times without failure:
./cmd/nerdctl< 1 sec per run./cmd/nerdctl/completion< 1 sec per run./cmd/nerdctl/issues< 10 secs per run./cmd/nerdctl/system< 10 secs per run./cmd/nerdctl/volume< 10 secs per run./cmd/nerdctl/network< 10 secs per run./cmd/nerdctl/image< 30 secs per run./cmd/nerdctl/ipfsWORK IN PROGRESS rn:
./cmd/nerdctl/builder./cmd/nerdctl/containerNOT part of this PR:
./cmd/nerdctl/login./cmd/nerdctl/compose