pkg/api/types: remove dependencies on nerdctl #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sondavidb
force-pushed
the
remove-netutil-imgutil-from-types
branch
from
dbd7979
to
21c8507
Compare
|
Want to confirm these are just flaky tests? Seems to be similar to other tests failing in the open PRs. Also sorry @djdongjin I force pushed right after your review so I think it dismissed it 😅 |
Yeah seems flaky tests, most errrors look related to cosign. |
|
Thanks, could you rebase, then the CI should be green |
pkg/api/types had a dependency on netutil and imgutil packages. This would create issues with circular dependencies, e.g. in containerd#2638 imgutil could not import types due to its dependency on netutil. This change moves NetworkCreateOptions and RemoteSnapshotterFlags into types to remove any future circular dependencies. This should also help us to clean our function headers, since we no longer need to explode the options struct into many different pieces. Signed-off-by: David Son <[email protected]>
sondavidb
force-pushed
the
remove-netutil-imgutil-from-types
branch
from
21c8507
to
70ee810
Compare
|
Rebase done, CI looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg/api/types had a dependency on netutil and imgutil packages. This would create issues with circular dependencies, e.g. in #2638 imgutil could not import types due to its dependency on netutil. This change moves NetworkCreateOptions and RemoteSnapshotterFlags into types to remove any future circular dependencies.