Add CNI configuration size limit #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeZappa87
force-pushed
the
mzappa/limitfilesize
branch
2 times, most recently
from
4f6d815
to
135001e
Compare
Signed-off-by: Michael Zappa <[email protected]>
MikeZappa87
force-pushed
the
mzappa/limitfilesize
branch
from
135001e
to
8f59f25
Compare
mikebrow
reviewed
Jul 23, 2024
| file, err := os.Open(filepath) | ||
|
|
||
| if err != nil { | ||
| return false, err |
There was a problem hiding this comment.
not there is .. fine should fail to exist in a different way
There was a problem hiding this comment.
by is fine, I mean since the file does not exist it is not larger than max and should be ignored here .. just return true...
| fileInfo, err := file.Stat() | ||
|
|
||
| if err != nil { | ||
| return false, err |
Co-authored-by: Mike Brown <[email protected]> Signed-off-by: Mike Zappa <[email protected]>
Co-authored-by: Mike Brown <[email protected]> Signed-off-by: Mike Zappa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.