Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore GRPC methods in the main package for older versions of containerd #17

Closed
wants to merge 1 commit into from

Conversation

jsternberg
Copy link

The current version of containerd uses the API from v0.1.0 of this library. This restores the GRPC methods that used to be in the main package while keeping the new location so existing code continues to work. The new locations are preserved and the old locations can be deprecated at a later time.

Copy link
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont we hit the same issue with http errors also that was moved into a separate package as part of #5

@dmcgowan
Copy link
Member

We will just need to fix the branches which moved to 0.1.0 once we have a 1.0 tag here. It might have been premature to update 1.7 branch to use 0.1.0.

@dmcgowan dmcgowan closed this Aug 16, 2024
@jsternberg jsternberg deleted the restore-grpc branch August 16, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants