Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: update to go1.19 as minimum, and add go1.22.x to GHA #342

Merged
merged 2 commits into from
Jun 21, 2024
Merged

go.mod: update to go1.19 as minimum, and add go1.22.x to GHA #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d70f65f
go.mod: update to go1.19 as minimum
thaJeztah Jun 21, 2024
d726ca6
gha: also test on go1.22.x
thaJeztah Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: '1.20.x'
go-version: '1.22.x'
cache-dependency-path: src/github.com/containerd/cgroups

- name: Project checks
Expand All @@ -50,7 +50,7 @@ jobs:

strategy:
matrix:
go-version: [1.19.x, 1.20.x]
go-version: [1.19.x, 1.21.x, 1.22.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop 1.19

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my thinking here was to keep a minimum version (unless we had a strong reason to drop it), then check current versions.

I'm fine with dropping 1.19 by now probably, although "if it works", then 🤷 .

I'll drop the 1.20, and keep the upper-bound to 1.21, 1.22 as suggested.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh! I read the diff wrong, thought it was a suggestion, but I already changed to 1.21, 1.22 🤦 😂


steps:
- name: Checkout cgroups
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:

strategy:
matrix:
go-version: [1.19.x, 1.20.x]
go-version: [1.19.x, 1.21.x, 1.22.x]
# Ubuntu-20.04 has cgroups v1 default; Ubuntu-22.04 has cgroups v2 default.
os: [ubuntu-20.04, ubuntu-22.04]

Expand Down
2 changes: 1 addition & 1 deletion cmd/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/containerd/cgroups/cmd

go 1.18
go 1.19

replace github.com/containerd/cgroups/v3 => ../

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/containerd/cgroups/v3

go 1.18
go 1.19

require (
github.com/cilium/ebpf v0.11.0
Expand Down