Skip to content

Add GetSnapshot RPC #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add GetSnapshot RPC #586

wants to merge 1 commit into from
+1,452 −1,167

Conversation

xing-yang
Copy link
Contributor

What type of PR is this?
feature

What this PR does / why we need it:
This PR adds a GetSnapshot RPC

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce an API-breaking change?:

Adds GetSnapshot RPC.

bswartz
bswartz requested changes Apr 18, 2025
View reviewed changes
bswartz
bswartz approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@bswartz bswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

nixpanic
nixpanic reviewed Apr 22, 2025
View reviewed changes
Copy link

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! You probably want to squash the commits into one before it gets merged?

@xing-yang
Copy link
Contributor Author

Squashed the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic left review comments

@bswartz bswartz bswartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xing-yang @nixpanic @bswartz