Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functions related to the debugger into pingpong #526

Closed
wants to merge 7 commits into from

Conversation

Cath3876
Copy link

@Cath3876 Cath3876 commented Dec 4, 2023

I added the functions related to the new interceptor with the basic functionality to accept or decline events. In main.go of the pingpong application, I added a few lines to use this interceptor

Schmit Catherine and others added 7 commits November 13, 2023 14:57
@matejpavlovic
Copy link
Contributor

matejpavlovic commented Dec 4, 2023

Thanks for the PR Catherine!

Before I go through it, could you please rebase the debugger branch on top of visualization and make only the actual changes appear in a single commit? It seems like all but one of the commits here have already been merged as part of #524. The usual workflow is the following:

  • Pull changes from the upstream branch (filecoin-project:visualization in our case) into andreaj00:visualization
  • Commit your code to a new branch from there (i.e., the debugger branch would extend the visualization branch) or rebase the branch with the code on top of visualization
  • Only then push.

This way, the PR will only show the relevant changes (and accidental overwriting of code with some old version is avoided too).

Also, the linter is complaining about this commit. You can see the errors either by running make lint in the mir directory (you need to have golangci-lint installed for that) or directly on GitHub, in the "Files changed" tab of this PR.

I'll have a look at the actual code as soon as these little issues are fixed.
Since you already pushed the current branch, you might need to do a force push instead of a normal one.

@Cath3876 Cath3876 closed this Dec 7, 2023
@Cath3876 Cath3876 deleted the debugger branch December 7, 2023 18:48
@Cath3876 Cath3876 restored the debugger branch December 7, 2023 18:51
@Cath3876 Cath3876 deleted the debugger branch December 7, 2023 18:51
@Cath3876 Cath3876 restored the debugger branch December 7, 2023 18:51
@Cath3876 Cath3876 deleted the debugger branch December 7, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants