Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General events #525

Merged
merged 18 commits into from
Dec 25, 2023
Merged

Conversation

matejpavlovic
Copy link
Contributor

Start generalizing event representation in Mir, loosening the dependency on protobufs.
Define Event as an interface, make the core of Mir only use this interface type, and allow any packages to implement this interface. The protobuf implementation would only be one such package.

As a proof of concept, add a new version of the Ping-Pong toy application that uses custom Ping and Pong events / messages.

The biggest challenge is not as much the core of Mir, which is rather simple and uses events in a very general way, but some general-purpose modules. Those should, ideally, be usable by as many other modules as possible, without locking those other modules to the usage of any specific event types. This has already partly been addressed for the grpc networking module, but in general there is still a lot of work to do.

@matejpavlovic matejpavlovic force-pushed the general-events branch 2 times, most recently from 76ac2f3 to 05f877e Compare December 17, 2023 20:48
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
@matejpavlovic matejpavlovic merged commit 78e673f into consensus-shipyard:main Dec 25, 2023
5 checks passed
@matejpavlovic matejpavlovic deleted the general-events branch December 25, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant