-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General events #525
Merged
matejpavlovic
merged 18 commits into
consensus-shipyard:main
from
matejpavlovic:general-events
Dec 25, 2023
Merged
General events #525
matejpavlovic
merged 18 commits into
consensus-shipyard:main
from
matejpavlovic:general-events
Dec 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejpavlovic
force-pushed
the
general-events
branch
2 times, most recently
from
December 17, 2023 20:48
76ac2f3
to
05f877e
Compare
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
Signed-off-by: Matej Pavlovic <[email protected]>
matejpavlovic
force-pushed
the
general-events
branch
from
December 23, 2023 20:31
279672b
to
2ef8b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start generalizing event representation in Mir, loosening the dependency on protobufs.
Define
Event
as an interface, make the core of Mir only use this interface type, and allow any packages to implement this interface. The protobuf implementation would only be one such package.As a proof of concept, add a new version of the Ping-Pong toy application that uses custom
Ping
andPong
events / messages.The biggest challenge is not as much the core of Mir, which is rather simple and uses events in a very general way, but some general-purpose modules. Those should, ideally, be usable by as many other modules as possible, without locking those other modules to the usage of any specific event types. This has already partly been addressed for the
grpc
networking module, but in general there is still a lot of work to do.