This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
CI: test infra scripts. #368
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really shouldn't be needing this...
Currently, these scripts build a Docker image. Simultaneously, they also expect a local Fendermint binary. It is strictly used to craft the genesis block. This is suboptimal because it requires duplicate compilation work, thus slowing down the user who just wants to get started quickly. The cargo graphs involved here are also quite heavy (1200+ packages), and some dependencies like rocksdb can take over 20min to compile. This PR adapts the testnode target/tasks to use the Fendermint binary inside the Docker image. In the future, the Docker image can be downloaded to make getting from zero to hero even breezier. TODO: adapt the testnet targets. This will require a bit more work since they use loops within scripts.
This also removes a significant amount of logic duplication between the testnode and testnet variants. More cleanup is needed.
- Detail system prerequisites (e.g. Docker, Rust, etc.) and provide instructions for Linux (Ubuntu). - Add missing details for when users start from scratch (which is the most probable scenario). - Add explanations and clean up.
... since the infra scripts now use Docker images.
Signed-off-by: Alfonso de la Rocha <[email protected]>
You'll need to place it under ~/.ipc/keys/validator_key.sk
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.