Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

FM-186: Fix rust-toolchain action version #199

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

jsoares
Copy link
Contributor

@jsoares jsoares commented Aug 16, 2023

@aakoshh Apologies but I missed this while reviewing #188. When specifying the toolchain, we should use the master branch of the action rather than stable (per https://github.com/dtolnay/rust-toolchain#inputs). I don't think it breaks anything right now but better avoid unsupported combinations.

@jsoares jsoares requested a review from aakoshh August 16, 2023 13:43
@aakoshh
Copy link
Contributor

aakoshh commented Aug 17, 2023

@jsoares good catch, thanks! I was rather confused about how to interpret the tag in the uses, and missed this comment.

Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@aakoshh aakoshh merged commit e0656eb into main Aug 17, 2023
6 checks passed
@aakoshh aakoshh deleted the fm-186-fix-install branch August 17, 2023 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants