Switch to hook-based implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this library only offers support for render props.
To offer more flexibility, the base features can be implemented using the
useSubscribablehook.With this, the
Subscribecomponent becomes much shorter.Additionally, this PR fixes warnings for unsafe lifecycle methods (since no more class components are beeing used).
Even if the API and the behavior of the Subscribe Component stays exactly the same, this is still a breaking change, since we had to bump the Version of React.
(to test hook-based components, enzyme and the development react version had to be bumped and shallow rendering could not be used anymore, since enzyme fires effects only in full rendering)