-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wip #12
base: master
Are you sure you want to change the base?
Wip #12
Commits on Mar 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ef6bea3 - Browse repository at this point
Copy the full SHA ef6bea3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fceaa0f - Browse repository at this point
Copy the full SHA fceaa0fView commit details -
Add flag for LCM, as well as a reverse method.
Configuration menu - View commit details
-
Copy full SHA for f84aa85 - Browse repository at this point
Copy the full SHA f84aa85View commit details -
lcm: port implementation from Riss
The current version compiles, but does not respect the PT changes yet. The implemented parameters should be functional. By default, LCM is not active.
Configuration menu - View commit details
-
Copy full SHA for 07f0c24 - Browse repository at this point
Copy the full SHA 07f0c24View commit details -
lcm: set PT level to current node level
When a clause is modified via LCM, tracking the PT level is difficult. As an over approximation, use the level of the current node. This way, we can at least use LCM, and still share clauses downwards correctly. For now, this is good enough, compared to not being able to share clauses at all.
Configuration menu - View commit details
-
Copy full SHA for 5be8767 - Browse repository at this point
Copy the full SHA 5be8767View commit details -
Track the share indexes during LCM. This way, we do not loose sharing information when doing LCM.
Configuration menu - View commit details
-
Copy full SHA for 40310f3 - Browse repository at this point
Copy the full SHA 40310f3View commit details -
pcasso: try to avoid local data structures
Move vector initialization 2 loops out, to reduce the number of re-alloactions.
Configuration menu - View commit details
-
Copy full SHA for 82e81e0 - Browse repository at this point
Copy the full SHA 82e81e0View commit details -
pcasso: get learnts_indeces right
When using an index to point into the learnts vector, make sure the items in that vector are valid, or in release mode are dropped to not crash the solver. This was found when using LCM which modified the learnts vector.
Configuration menu - View commit details
-
Copy full SHA for 275cf18 - Browse repository at this point
Copy the full SHA 275cf18View commit details -
pcasso.sh: actually read tmp dir
The tmp dir variable has been read from $3, while $2 was the actual aim.
Configuration menu - View commit details
-
Copy full SHA for 96359f9 - Browse repository at this point
Copy the full SHA 96359f9View commit details -
splitting: use var based index
In the old version, the wrong variable has been used as index value, leading to out of bound errors.
Configuration menu - View commit details
-
Copy full SHA for bc4d5af - Browse repository at this point
Copy the full SHA bc4d5afView commit details -
splitting: only compute score for candidates
If there are no candidate literals to compute a score for, stop the computation, and skip.
Configuration menu - View commit details
-
Copy full SHA for 797ae6a - Browse repository at this point
Copy the full SHA 797ae6aView commit details -
splitting: handle no-split case
The split variable next has to be initialized, such that in case of failures during computing the candidates, e.g. due to too small formulas, there lit_Undef value can still be returned. Consequently, make sure nobody consumes lit_Undef as an index.
Configuration menu - View commit details
-
Copy full SHA for 892cf06 - Browse repository at this point
Copy the full SHA 892cf06View commit details -
master: allow getting stuck more often
As getting stuck might be due to a race condition, allow the solver to see this condition more often before actually aborting the search. On the other hand, make sure we assert before exit, so that debugging would be doable, and the problem can be identified during fuzzing.
Configuration menu - View commit details
-
Copy full SHA for 10133b0 - Browse repository at this point
Copy the full SHA 10133b0View commit details -
master: do not blindly set to unknown
When multiple slaves work on the same node, make sure they do not overwrite the state of each other. Only set a state to unknown, if the node actually has an unknown state.
Configuration menu - View commit details
-
Copy full SHA for 1c1cbc3 - Browse repository at this point
Copy the full SHA 1c1cbc3View commit details -
master: always write unsat result
Currently, the stopUnsatChilds option had to be set to write the unsat state for a node. However, the state should always be written. Hence, the check for the option is moved closer to actually running the related algorithm.
Configuration menu - View commit details
-
Copy full SHA for 3abccb4 - Browse repository at this point
Copy the full SHA 3abccb4View commit details -
pcasso: clear clauses to share before reduceDB
In the reduceDB, new clauses are added to the clauses to be shared, but no clauses are removed. This way, faulty pointers might be used, as the clauses that are shared might become invalid, or wrong indexes are used.
Configuration menu - View commit details
-
Copy full SHA for a21fc34 - Browse repository at this point
Copy the full SHA a21fc34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20c2e54 - Browse repository at this point
Copy the full SHA 20c2e54View commit details -
solverpt: do not share eagerly
When we know a level does not have clauses to share, do not lock the level, but instead skip the level right away.
Configuration menu - View commit details
-
Copy full SHA for b6262a0 - Browse repository at this point
Copy the full SHA b6262a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b05be71 - Browse repository at this point
Copy the full SHA b05be71View commit details
Commits on Mar 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5f290f8 - Browse repository at this point
Copy the full SHA 5f290f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5b624e - Browse repository at this point
Copy the full SHA a5b624eView commit details
Commits on Mar 11, 2020
-
lasplitting: handle unit conflicts
We should not have unit clauses as conflicts in the first place. Learnt clauses can become units. Hence, they need to be treated accordingly, especially added on level 0.
Configuration menu - View commit details
-
Copy full SHA for a9ad8fa - Browse repository at this point
Copy the full SHA a9ad8faView commit details -
lasplitting: do not shrink watched lits
The current implementation would allow to drop first lits of clauses that are used for splitting. Do not allow this, as this might result in unsound behavior.
Configuration menu - View commit details
-
Copy full SHA for 3bd94fb - Browse repository at this point
Copy the full SHA 3bd94fbView commit details -
lasplitting: do not use learnt units
While learning units is good, the extra decision level jumps might be hard to maintain. Hence, for now, do not use the units right away.
Configuration menu - View commit details
-
Copy full SHA for cc67787 - Browse repository at this point
Copy the full SHA cc67787View commit details -
To make sure we do not stop at a higher level, set the lastLevel accordingly.
Configuration menu - View commit details
-
Copy full SHA for 13357af - Browse repository at this point
Copy the full SHA 13357afView commit details -
bug: add another example for unsound behavior
When building the debug version of the solver, the added formula is most of the time reported as unsatisfiable, although it is satisfiable. This is the invocation to trigger the bug on a 4 core machine: ./pcasso -verb=2 -model -child-count=7 -threads=3 \ -print-tree -verbosity=6 cnfs/bug-180394467.cnf
Configuration menu - View commit details
-
Copy full SHA for 33540c4 - Browse repository at this point
Copy the full SHA 33540c4View commit details
Commits on Apr 12, 2020
-
sharing: store pt level before failing
In case a node is solved by receiving shared clauses, make sure we store the ptlevel for failing before.
Configuration menu - View commit details
-
Copy full SHA for dcbe631 - Browse repository at this point
Copy the full SHA dcbe631View commit details -
unsat: allow to suppress UNSAT
As the solver is unsound, we might want to suppress unsat answers, and turn them into unknown, to result in a sound solver for satisfiable formulas again, without fixing the bug in the first place.
Configuration menu - View commit details
-
Copy full SHA for 420c276 - Browse repository at this point
Copy the full SHA 420c276View commit details -
output: print state when verbose
Show a little more info about state evaluation in verbose mode.
Configuration menu - View commit details
-
Copy full SHA for c950451 - Browse repository at this point
Copy the full SHA c950451View commit details -
Configuration menu - View commit details
-
Copy full SHA for 888a695 - Browse repository at this point
Copy the full SHA 888a695View commit details -
lcm: set level for dropped literals
We need to track causalities of dropped literals. This was not implemented in original LCM. Signed-off-by: Norbert Manthey <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8b6780c - Browse repository at this point
Copy the full SHA 8b6780cView commit details
Commits on Apr 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for cec08b1 - Browse repository at this point
Copy the full SHA cec08b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 837c501 - Browse repository at this point
Copy the full SHA 837c501View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd681ae - Browse repository at this point
Copy the full SHA bd681aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f9c215 - Browse repository at this point
Copy the full SHA 9f9c215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f130c6 - Browse repository at this point
Copy the full SHA 1f130c6View commit details