Support parallel rspec tests #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrencegripper
changed the title
lawrencegripper
commented
May 18, 2023
| // For format details, see https://aka.ms/devcontainer.json. For config options, see the | ||
| // README at: https://github.com/devcontainers/templates/tree/main/src/typescript-node | ||
| { | ||
| "name": "Node.js & TypeScript", |
There was a problem hiding this comment.
Happy to remove this one, added as I was testing in codespaces but haven't tweaked it to have everything needed, just a basic starting point
| @@ -5,6 +5,7 @@ on: | |||
| branches: | |||
| - main | |||
| pull_request: {} | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Let's you manually start it from the ui for a branch
| @@ -10,8 +10,9 @@ | |||
| "--extensionDevelopmentPath=${workspaceFolder}" | |||
| ], | |||
| "outFiles": [ | |||
| "${workspaceFolder}/out/src" | |||
| ] | |||
| "${workspaceFolder}/out/**/*.js" | |||
There was a problem hiding this comment.
I found this helped the debugger correctly pick up break points, guess it meant source maps where available but not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using
parallel_rspecto the test adapter.The main changes require where:
START_OF_TEST_JSONline I'd get 1 per parallel execution and need to merge them all back together.Note the parallel test suite partitions by file so it only really makes sense to use this when the whole suite is being run.
For the codebase I work on this made it go from 7mins to 1min to execute all tests 🥳
CI Action here is ✔️ https://github.com/lawrencegripper/vscode-ruby-test-adapter/actions/runs/5015831721
Here it is in action 👇
Kazam_screencast_00010.webm