Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update podspecs for v1.0.0-rc1 #287

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Update podspecs for v1.0.0-rc1 #287

merged 2 commits into from
Aug 1, 2024

Conversation

rebello95
Copy link
Collaborator

No description provided.

@rebello95
Update podspecs for v1.0.0-rc1
fd00c46 
Signed-off-by: Michael Rebello <[email protected]>
@rebello95 rebello95 requested a review from jhump July 31, 2024 16:32
jhump
jhump approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Aside: we should probably address all of the annotations on unchanged files before the next release candidate.

@rebello95
Copy link
Collaborator Author

Aside: we should probably address all of the annotations on unchanged files before the next release candidate.

Sorry, @jhump not quite sure what you're referring to - can you clarify?

@jhump
Copy link
Member

jhump commented Aug 1, 2024

When I look at the file view of this PR (and other recent PRs), I see a bunch of things like this:
image

@rebello95
Copy link
Collaborator Author

Thanks for flagging @jhump. I merged main into this PR because #284 should have fixed those issues, and indeed they've disappeared from the file viewer now

@rebello95 rebello95 merged commit d6d829e into main Aug 1, 2024
14 of 15 checks passed
@rebello95 rebello95 deleted the update-cocoapods branch August 1, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhump jhump jhump approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebello95 @jhump