Switch to eslint-plugin-n

connectrpc · Nov 20, 2023 · ff0b7f2 · ff0b7f2
1 parent c171ecc
commit ff0b7f2
Show file tree

Hide file tree

Showing 3 changed files with 73 additions and 90 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -6,7 +6,7 @@ module.exports = {
   },
   root: true,
   ignorePatterns: ["packages/*/dist/**"],
-  plugins: ["@typescript-eslint", "node", "import"],
+  plugins: ["@typescript-eslint", "n", "import"],
   // Rules and settings that do not require a non-default parser
   extends: ["eslint:recommended"],
   rules: {
@@ -49,35 +49,23 @@ module.exports = {
     {
       files: ["**/*.{js,mjs,cjs}"],
       parserOptions: {
-        ecmaVersion: 2020,
+        ecmaVersion: 13, // ES2022 - https://eslint.org/docs/latest/use/configure/language-options#specifying-environments
       },
-      extends: ["eslint:recommended", "plugin:node/recommended"],
+      extends: ["eslint:recommended", "plugin:n/recommended"],
       rules: {
-        "node/shebang": "off", // this plugin only determines shebang necessary for files that are in a package.json "bin" field
-        "node/exports-style": ["error", "module.exports"],
-        "node/file-extension-in-import": ["error", "always"],
-        "node/prefer-global/buffer": ["error", "always"],
-        "node/prefer-global/console": ["error", "always"],
-        "node/prefer-global/process": ["error", "always"],
-        "node/prefer-global/url-search-params": ["error", "always"],
-        "node/prefer-global/url": ["error", "always"],
-        "node/prefer-promises/dns": "error",
-        "node/prefer-promises/fs": "error",
-        "no-process-exit": "off",
-        "node/no-unsupported-features/es-builtins": [
-          "error",
-          {
-            version: ">=16.0.0",
-            ignores: [],
-          },
-        ],
-        "node/no-unsupported-features/node-builtins": [
-          "error",
-          {
-            version: ">=16.0.0",
-            ignores: [],
-          },
-        ],
+                  "n/shebang": "off", // this rule reports _any_ shebang outside of an npm binary as an error
+                  "n/prefer-global/process": "off",
+                  "n/no-process-exit": "off",
+                  "n/exports-style": ["error", "module.exports"],
+                  "n/file-extension-in-import": ["error", "always"],
+                  "n/prefer-global/buffer": ["error", "always"],
+                  "n/prefer-global/console": ["error", "always"],
+                  "n/prefer-global/url-search-params": ["error", "always"],
+                  "n/prefer-global/url": ["error", "always"],
+                  "n/prefer-promises/dns": "error",
+                  "n/prefer-promises/fs": "error",
+                  "n/no-unsupported-features/node-builtins": "error",
+                  "n/no-unsupported-features/es-syntax": "error",
       },
     },
   ],

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -33,7 +33,7 @@
     "eslint": "^8.52.0",
     "eslint-import-resolver-typescript": "^3.6.1",
     "eslint-plugin-import": "^2.29.0",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^16.3.1",
     "prettier": "^3.0.3",
     "typescript": "^5.2.2"
   },