-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blocking unary generation #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure to add docs on this to the Connect site as well
@rebello95 Do you prefer "synchronous" or "blocking"? |
Don't have a strong preference, but leaning towards |
/** | ||
* Execute the underlying request. | ||
*/ | ||
fun execute(): ResponseMessage<Output> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What prevents this from being called multiple times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't prevented. OkHttp also does this!
library/src/main/kotlin/build/buf/connect/ProtocolClientInterface.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/build/buf/connect/impl/ProtocolClient.kt
Outdated
Show resolved
Hide resolved
library/src/main/kotlin/build/buf/connect/impl/ProtocolClient.kt
Outdated
Show resolved
Hide resolved
9abe7e6
to
e5deb8b
Compare
Providing options for generating synchronous methods for unary RPC calls: