Update to v1.0.3 of conformance suite #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e client for 'suspend' style unary RPCs Signed-off-by: Josh Humphries <[email protected]>
jhump
force-pushed
the
jh/update-latest-conformance
branch
from
399d064
to
0d62942
Compare
pkwarren
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new test cases in the latest suite revealed errors in how cancelation of unary RPCs was implemented in the conformance client, but it only impacted the "suspend" style of invocation (callback and blocking styles worked fine).
The issue is that the
coroutineScopefunction doesn't return until all child coroutines complete. So even though the helper was usinglaunchto create a concurrent coroutine, the whole thing blocked until that job finished. In order to fix that, I had to move thecoroutineScopecall higher up the call stack (out of a helper method on theUnaryClientadapter and into the conformanceClientitself), so it also made sense to move the relatedInvokeStyleenum.Most of the diff is inlining that helper into the conformance client. But I also had to add an exception handler to the async job, to actually complete the future (with an exception) if the coroutine gets canceled (which is the only way we expose canceling a suspend unary RPC).