Remove old crosstest stuff #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @drice-buf, before the current conformance suite, we had an approach that required clients to implement all of the test cases themselves (instead of a generic client that was data-driven with test case input) and then run those against a large number of server implementations that were distributed via Docker containers. This pull request rips out the old stuff. When I first added the new conformance suite, I left the old one in place, to let them run in parallel. But the new tests have identified a number of issues and are far more thorough, so there's no reason to keep running the old stuff. |
pkwarren
approved these changes
Mar 7, 2024
pkwarren
pushed a commit
that referenced
this pull request
Apr 19, 2024
The new conformance tests are more than adequate replacements. So we can ditch the old tests now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new conformance tests are more than adequate replacements. So we can ditch the old tests now.