Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify UnaryBlockingCall #225

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Simplify UnaryBlockingCall #225

merged 4 commits into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. Simplify UnaryBlockingCall 

    - It's now just an interface, and the implementation is
  in the impl package (just like the stream interfaces).
- The implementation is simpler and thread-safe.
- No longer supports calling it more than once. This was
  incorrectly implemented before since it became impossible
  to cancel earlier invocations (and was not thread-safe).
  Much simpler to just not allow this than to fix it.
    @jhump
    jhump committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    536d92a View commit details
    Browse the repository at this point in the history

  2. add some type aliases and comments to clarify the UnaryCall impl; add… 

    … basic unit tests
    @jhump
    jhump committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4af7f5d View commit details
    Browse the repository at this point in the history

  3. make tests faster/deterministic; add test for when cancel is called b… 

    …efore execute
    @jhump
    jhump committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    ea06ddc View commit details
    Browse the repository at this point in the history

  4. consolidate test further

    @jhump
    jhump committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5e23db9 View commit details
    Browse the repository at this point in the history