Makes ResponseStream actually implement ReceiveChannel #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of containing a property of type ReceiveChannel. Also makes ClientStream extend RequestStream. Adds copyFromChannel helpers, to make it easier to use channels as sources of request data for client- and bidi-streaming RPCs.
pkwarren
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small extension on top of the previous PR (#213).
Instead of response streams having a
messagesproperty of typeReceiveChannel, theResponseStreaminterface extendsReceiveChannel. This just removes a small amount of indirection, hopefully making it easier to use.This also makes
ClientStreamextendRequestStream, since its interface is a strict superset.Finally, for the use case described by @kohenkatz in that previous PR, about possibly using channels as the way to get data into the request stream, this adds
copyFromChannelhelper functions for client- and bidi-streaming methods.