Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method stream type to generated code #172

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Add method stream type to generated code #172

merged 4 commits into from
Dec 8, 2023

Commits on Dec 7, 2023

  1. Add method stream type to generated code 

    It is useful to have the stream type in the generated code (similar to
other Connect implementations). In the future we may use this
information to optimize stream handling - for example, avoiding the
pipe/duplex/oneshot for server streaming calls to enable Connect over
HTTP/1.1. Update the generator to include the stream type in the
generated code.

Additionally, move the HTTP method to the HTTPRequest class - mutating a
method spec to determine which HTTP method to use seems wrong. We should
keep MethodSpec to contain only fields set from the generator.
    @pkwarren
    pkwarren committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    43230dd View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. review comments

    @pkwarren
    pkwarren committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    e2c8eb4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pkw/stream-type

    @pkwarren
    pkwarren committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b4e46d7 View commit details
    Browse the repository at this point in the history

  3. remove StreamType.UNKNOWN

    @pkwarren
    pkwarren committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3c7fc54 View commit details
    Browse the repository at this point in the history