Add conformance tests for lite runtime #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the conformance/google-javalite project to run tests with the lite runtime.
pkwarren
commented
Nov 9, 2023
| @@ -20,6 +20,10 @@ plugins: | |||
| - plugin: connect-kotlin | |||
| out: google-javalite/build/generated/sources/bufgen | |||
| path: ./protoc-gen-connect-kotlin/build/install/protoc-gen-connect-kotlin/bin/protoc-gen-connect-kotlin | |||
| opt: | |||
There was a problem hiding this comment.
Updated the lite tests to use generated code with the same args as the full runtime tests.
| compressionPools = listOf(GzipCompressionPool), | ||
| ), | ||
| ) | ||
| init(GoogleJavaProtobufStrategy()) |
There was a problem hiding this comment.
This is the only real change between the two clients.
| implementation(project(":conformance:common")) | ||
| implementation(project(":extensions:google-java")) | ||
| implementation(project(":extensions:google-javalite")) |
There was a problem hiding this comment.
These dependencies weren't correct before.
| import java.util.concurrent.TimeUnit | ||
|
|
||
| @RunWith(Parameterized::class) | ||
| class ConformanceTest( |
There was a problem hiding this comment.
I don't like the fact that this is a duplicate of the non-lite test (except for the serialization strategy), but I don't know a better way to share logic with different dependencies.
smaye81
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the conformance/google-javalite project to run tests with the lite runtime.