Allow separate client for streaming calls #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streaming calls often require longer timeouts (for long lived streams) and enabling pings (to keep the underlying connection alive). Update ConnectOkHttpClient to take a second OkHttpClient argument to the constructor to be used for streaming calls. Fixes #13.
rebello95
reviewed
Oct 10, 2023
Without some sort of long running test that relies on ping to keep it alive, I don't know if it is worth it. |
rebello95
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streaming calls often require longer timeouts (for long lived streams) and enabling pings (to keep the underlying connection alive). Update ConnectOkHttpClient to take a second OkHttpClient argument to the constructor to be used for streaming calls.
Fixes #13.