Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ErrorWriter to be codec agnostic #701

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Fix ErrorWriter to be codec agnostic #701

merged 5 commits into from
Mar 12, 2024

Commits on Mar 6, 2024

  1. Fix ErrorWriter to be codec agnostic

    This PR changes the ErrorWriter to be more lenient with classifying
    protocols. Errors codecs are agnostic to the codec used. Therefore we
    avoid checking the codec in classifying the request. IsSupported will
    return true for an unknown codec which allows the server to encode a
    better error message to the client. If not supported a 415 error response
    could be used to match gRPC server like handling. If not supported and
    trying to write an error the ErrorWriter will default to connects unary
    encoding.
    emcfarlane committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    51e2a91 View commit details
    Browse the repository at this point in the history
  2. Feedback

    emcfarlane committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    f2216ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    36448d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    d0dde2d View commit details
    Browse the repository at this point in the history
  2. Fix drop

    emcfarlane committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e1b7166 View commit details
    Browse the repository at this point in the history