Refactor http calls to support message payloads #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable client retries, the system now operates directly on message payloads instead of relying solely on io.Writers. This refacotr replaces write operations with send operations at message boundries. It introducces a new inteface, messagePayload, implemented by *bytes.Readers and *envelopes, enabling them to adopt sender operations.
jhump
reviewed
Dec 5, 2023
jhump
approved these changes
Dec 5, 2023
jhump
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable client retries, the http calls now operates directly on message payloads instead of relying solely on
io.Writers. This refactor replaces write operations with send operations at message boundaries. It introduces a new interface,messagePayload, implemented by*bytes.Readers and*envelopes, enabling them to adopt sender operations.Changes Made:
messagePayload, implemented by*bytes.Readerand*envelope, allowing for adoption of sender operations.messageSender, implemented by*duplexHTTPCall, which acts onmessagePayloadsto send the message.writeSenderforhttp.ResponseWriterto implementmessageSendervia converting send payloads to write operations.Objective:
The goal of this refactor is to facilitate client retries by directly manipulating message payloads rather than relying solely on
io.Writers. ThemessagePayloadinterface is a readable, seekable and sized payload which allows it to be replayed.This PR is part of the fix for #609 . It implements the groundwork for the handling of message payloads.