Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser fetch can support streaming request bodies #840

Closed
wants to merge 2 commits into from

Conversation

tshedor
Copy link

@tshedor tshedor commented Sep 28, 2023

This is a bug fix related to client-streaming requests.

Invoking a MethodKind.ClientStreaming method using a connect or grpc-web transport immediately throws the error "The fetch API does not support streaming request bodies."

This, however, appears to be a dated catch. Streaming as a request body is supported by most modern browsers using the default fetch.

This PR does a very light feature check to ensure backwards compatibility instead of checking against the method's kind.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tshedor
Copy link
Author

tshedor commented Sep 28, 2023

This may be a half-baked duplicate of #670 , and if that's the case, I'm sorry for adding to the maintainer's administrative work

@tshedor tshedor closed this Sep 28, 2023
@timostamm
Copy link
Member

Hey Tim, thanks for bringing it up! Unfortunately, only Chrome supports streaming request bodies yet, but it's not obvious from the documentation out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants