Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

WIP Work/possum #5

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

WIP Work/possum #5

wants to merge 64 commits into from

Conversation

dustinmm80
Copy link
Contributor

Opening PR for @dividedmind

Copy link
Contributor

@dividedmind dividedmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python is a harsh mistress ;)

@kgilpin
Copy link
Contributor

kgilpin commented Nov 3, 2017

@dividedmind @dustinmm80 This is pretty interesting actually. This is a working API + CLI for Possum afaik.

@dustinmm80
Copy link
Contributor Author

I think we can use some of this to get a working Conjur v5 Python client. But we can probably remove all the CLI stuff right? We already have a Ruby CLI, a Python CLI doesn't add much to the mix. Less code the better :)

@ryanprior
Copy link
Contributor

I actually thinking having multiple Conjur CLIs owns, as long as they all have tests.

I'd propose splitting out the CLI stuff into a separate PR, merging this, and merging the Python CLI once it has tests.

@dustinmm80
Copy link
Contributor Author

I disagree. Why would having more than one CLI be a good thing? It increases the work we have to do (maintaining multiple CLIs) without providing any more functionality to our end users.

I think we would be better served using this PR as a foundation for a Python API client that works with Conjur 4 and 5.

@kgilpin
Copy link
Contributor

kgilpin commented Dec 5, 2017

For what it's worth, I don't want to have two CLIs either. This was a fun experiment but I think it should be retired now.

I also agree that our API libraries should work with both v4 and v5 with a setting/env var switch.

We should consider bringing that approach to the Ruby API as well. If I call a command on the Ruby (5.x) library, I would like that command to try and work against whatever backend I have (understanding that's impossible in some cases).

@dustinmm80 dustinmm80 changed the title Work/possum WIP Work/possum Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants