Rewrite a part of ConsistencyChecks.go #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vqhuy
force-pushed
the
remove-str-from-df
branch
3 times, most recently
from
97fa511
to
466a496
Compare
vqhuy
force-pushed
the
remove-str-from-df
branch
from
466a496
to
494cb36
Compare
vqhuy
force-pushed
the
remove-str-from-df
branch
from
494cb36
to
3bfd090
Compare
vqhuy
force-pushed
the
refactor-tests
branch
2 times, most recently
from
1644b01
to
64bf084
Compare
vqhuy
force-pushed
the
remove-str-from-df
branch
from
3bfd090
to
edb358d
Compare
* Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic * Comment some tests which will be rewritten later
vqhuy
force-pushed
the
remove-str-from-df
branch
from
711a0ca
to
783b925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove STR field from DirectoryResponse (Close Make STR field optional in lookup and monitoring response #181)
Rewrite ConsistencyChecks.go: separate UpdateSTR and VerifyConsistency logic
Comment some tests which will be rewritten later