Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start 3.6.0 release #537

Merged
merged 49 commits into from
Jul 10, 2024
Merged

Start 3.6.0 release #537

merged 49 commits into from
Jul 10, 2024

Conversation

marcopeereboom
Copy link
Contributor

It worked so well to have a release branch last time so I made a new one.

Let's pile stuff in here and whenever we are convinced we have enough we'll hit release..

@LordReg
Copy link
Contributor

LordReg commented Nov 2, 2023

Yeah, it's nice to prepare on the side first and merge in any PRs, etc.

Want to push a patch release first if you have no objection.

@marcopeereboom
Copy link
Contributor Author

Want me to push a 3.5.1 tag?

@LordReg
Copy link
Contributor

LordReg commented Nov 7, 2023

Still need to add the release info to the CHANGELOG.md file so its better to not push the release script tag. Need to create a tag on the final release commit to be able to select it when creating the GitHub release. I'll go ahead and do the same as last time.

@marcopeereboom
Copy link
Contributor Author

Any news on the patch release?

@LordReg
Copy link
Contributor

LordReg commented Nov 25, 2023

@marcopeereboom
Copy link
Contributor Author

Awesome. So I can use that as the new 3.6.0 base?

@marcopeereboom
Copy link
Contributor Author

anything yall?

marcopeereboom and others added 2 commits February 5, 2024 13:51
Enables quirks to be assigned to windows using a combination of
different quirk entries.

When  a window is managed, quirk entries are applied in the order
specified in the configuration file. The assignment operator determines
how the quirks are applied. When assigning quirks with '=', quirks are
replaced on matching windows. To add or remove quirks, assign them with
'+=' or '-=' instead.

Example:
    quirk[.*] = FLOAT # Float all windows by default.
    quirk[XTerm] -= FLOAT # Don't float XTerm windows.
    quirk[.*:ws10] += WS[10] # Force workspace 10 and keep other quirks.
    quirk[Pcmanfm] += IGNORESPAWNWS # Add quirk to PCManFM windows.

Closes #107
@LordReg
Copy link
Contributor

LordReg commented Feb 5, 2024

pushed rebase to the latest fixes along with the first new feature 😃

@marcopeereboom
Copy link
Contributor Author

wheee!!!

andreabolognani and others added 17 commits February 17, 2024 20:25
Login managers that use xsession files will parse this key and
set $XDG_CURRENT_DESKTOP accordingly. That environment variable,
in turn, will influence other components that can exhibit
desktop-specific behavior.
I've added this a few years ago (9caab3f) after Lintian
started complaining about it.

Looking back, that was probably not the right call: the
validation that is performed for .desktop files is based on the
assumption that they are describing applications, which makes
sense as that's the overwhelming majority of .desktop files out
there, but doesn't quite apply to us.

Looking at other xsession configurations shipped in Debian,
none of them includes the Keywords key. Let's drop it.
Set the maximum workspace index (counting from 1) to list in the status
bar workspace (+L) and urgency hint (+U) indicators. Workspaces beyond
this value will not be shown. Default is 0 (disabled).

Closes #549
According to EWMH spec, window managers must always set
_NET_DESKTOP_VIEWPORT to (0, 0) if desktops are never larger than the
root window.

Resolves #484
Remove the 10 color limit on options that accept a color list.

Extend 'bar_format' markup sequences to support color indexes above 9.

Add support for the '+=' operator with options that accept a color list.

Closes #564
Fix libswmhack.so should not need to be linked with libX11.

Improve libswmhack.so symbol lookup.
Extend 'bar_format' markup sequences to support font indexes above 9.
@vqns
Copy link
Contributor

vqns commented May 26, 2024

Just putting this here for the record: since 97b9c2c, libswmhack causes steam to crash on startup unless it is 32-bit. (Obviously unset LD_PRELOAD works as well)

@marcopeereboom
Copy link
Contributor Author

Ah good find!

Ok @LordReg comment on this PR when ready.

@marcopeereboom
Copy link
Contributor Author

Was that it @LordReg?

@LordReg
Copy link
Contributor

LordReg commented May 31, 2024

@marcopeereboom not quite, fixing the Steam issue

LordReg added 2 commits June 4, 2024 19:05
When _NET_ACTIVE_WINDOW is handled, avoid refocusing an already focused
window. Refocusing a window causes unintended pointer centering when
`warp_pointer` is enabled, such as when opening a link in a new browser
tab.
@wavexx
Copy link
Contributor

wavexx commented Jun 11, 2024

I'm noticing some new behavior (may be due to commit eed0243).

Previously, quirk[A:B:] would match a window with an empty title only. Now it behaves as quirk[A:B:.*]. Not sure if that's intended?

LordReg added 2 commits June 14, 2024 11:20
The pointer should not be centered on the focused window after
an EWMH _NET_WM_MOVERESIZE operation.
@LordReg
Copy link
Contributor

LordReg commented Jun 14, 2024

@wavexx Nice catch, fixed

@marcopeereboom
Copy link
Contributor Author

How we doing guys? Ready for a release yet?

@wavexx
Copy link
Contributor

wavexx commented Jun 21, 2024

The only thing I noticed so far is that sometimes menus from qt5's menu bar stop showing up (hard to say if they stay under the main window or show in some invisible region). It seems that once the main window gets into this state, it stays that way until you restart spectrwm (while keeping the program active). Toggling float on the window or changing workspace layout doesn't change anything.

However it's rare, and I couldn't find a way to reproduce it reliably. I just noticed this on some programs that I was using and all are using qt5 (just speculation - might be general).

LordReg added 5 commits June 24, 2024 17:54
Enables changing the focus mode for specific focus situations.

For example, to use 'follow' focus mode except when windows map/unmap:

focus_mode = follow
focus_mode[map,unmap] = manual

Resolves #577
Avoids the possibility of stacking above any lock/screensaver windows
that happen to be running while (re)starting.
It is common for clients to only look at the geometry of the first
desktop in the list and apply it regardless of the actual desktop its
window is on. This can result in menu positioning issues, etc. For
improved compatibility, list the workarea of the screen (root window)
for each desktop.
@LordReg
Copy link
Contributor

LordReg commented Jun 27, 2024

@wavexx Should be fixed. I believe the issue you experienced has to do with the way Qt handles _NET_WORKAREA. It only looks at the geometry of the first entry in the list (i.e. ws1). It will position its menu window within that boundary. So the issue would occur if ws1 is/was on a different region.

@LordReg
Copy link
Contributor

LordReg commented Jul 9, 2024

@marcopeereboom Ready

@marcopeereboom marcopeereboom merged commit 3509555 into master Jul 10, 2024
@marcopeereboom
Copy link
Contributor Author

BOOM!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants