Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SandboxedSchemaRegistryClient does not impl. new registerWithResponse SR API #9983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spena
Copy link
Member

@spena spena commented Jun 23, 2023

Description

What behavior do you want to change, why, how does your patch achieve the changes?

Ksql SR schema registration fails because SandboxedSchemaRegistryClient does not implement the new API registerWithResponse.

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@spena spena requested a review from a team as a code owner June 23, 2023 14:51
Copy link

cla-assistant bot commented Nov 15, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant