Add x header reflection #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally to facilitate correlating the response with the request in the client for those clients who need to do so manually.
…o be returning a list at runtime - but a simple string at compile time
… bug with the code... good test.
…ean for reflect.xheaders
… into confluentinc-4.1.1-post # Conflicts: # kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestApplication.java # kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestConfig.java # kafka-rest/src/test/java/io/confluent/kafkarest/integration/ClusterTestHarness.java
… into feature/merge-v5.0.0
…he Load Balancer port is different to the direct access ports (i.e. lb uses 443 where direct access uses 8082) - this is important for consumer group responses.
…ost.port config test, re-flow'd some of the text in KafkaRestConfig to comply with Checkstyle line lengths.
Add idle timeout config
… into add-x-header-reflection # Conflicts: # docs/config.rst # kafka-rest-common/src/main/java/io/confluent/kafkarest/KafkaRestConfig.java # kafka-rest/src/main/java/io/confluent/kafkarest/KafkaRestApplication.java # kafka-rest/src/main/java/io/confluent/kafkarest/UriUtils.java # kafka-rest/src/test/java/io/confluent/kafkarest/integration/ClusterTestHarness.java # kafka-rest/src/test/java/io/confluent/kafkarest/unit/UriUtilsTest.java
|
@confluentinc It looks like @joncourt just signed our Contributor License Agreement. 👍 Always at your service, clabot |
|
Jon Court seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added reflection of headers beginning with X- (case-insensitive) from request to response. This change means we can accommodate the clients we have that match from request to response using an x-correlation-id header (mainframe).