Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set consumer setting max.poll.interval.ms to rest proxy setting of co… #515

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Set consumer setting max.poll.interval.ms to rest proxy setting of co… #515

wants to merge 3 commits into from

Commits on Nov 21, 2018

  1. Set consumer setting max.poll.interval.ms to rest proxy setting of co… 

    …nsumer.timeout.ms

If `consumer.timeout.ms` has been set to a value greater than the default value of `max.poll.interval.ms` and a consumer has set `auto.commit.enable=false` then it is possible the kafka brokers will consider a consumer as failed and release its partition assignments, while the rest proxy maintains a consumer instance handle. This then leads to an exception on the next call to poll, commitSync, or similar.

This commit sets max.poll.interval.ms equal to consumer.timeout.ms to ensure that kafka will not consider the consumer failed until the rest proxy does as well.
    @mmercedes
    mmercedes committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    d6e8426 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Update ConsumerManager.java 

    dont allocate just to call toString()
    @mmercedes
    mmercedes committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    81f30ce View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. retrigger ci

    @mmercedes
    mmercedes committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    8c3f7a3 View commit details
    Browse the repository at this point in the history