Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reporting modified record #720

Open
wants to merge 660 commits into
base: 10.0.x
Choose a base branch
from
Open

Fix reporting modified record #720

wants to merge 660 commits into from

Conversation

naveenmall11
Copy link
Member

Problem

https://confluent.slack.com/archives/C06HJ2VFQ5T
While projecting we were changing instance of record from InternalSinkRecord to SinkRecord and while reporting we were using modified records which was causing the original schema of messages to be changed while serialising again.

Solution

Changed the projection logic to not create a new SinkRecord.
Update kafka-connect-storage-common-parent to 11.2.5 that has above changes

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

Test Strategy

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

pbadani and others added 30 commits February 24, 2023 07:46
added service.yml for setting up semaphore pipeline
sp-gupta and others added 25 commits October 29, 2023 04:16
[CC-21863] Resolve plugin.discovery error
MINOR: Add diagnostic info for topic partition assignments
@naveenmall11 naveenmall11 requested a review from a team as a code owner February 20, 2024 13:48
Copy link

cla-assistant bot commented Feb 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Feb 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@naveenmall11 naveenmall11 requested a review from b-goyal February 20, 2024 13:51
@naveenmall11 naveenmall11 changed the base branch from master to 10.0.x February 21, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants