-
Notifications
You must be signed in to change notification settings - Fork 914
KIP 848: Added support for DescribeConsumerGroup for consumer protocol groups #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7fe5b90
Added support for describe consumer group for new protocol
PratRanj07 d45971f
style fix
PratRanj07 137dd1d
removed session timeout
PratRanj07 0e696d3
style fix
PratRanj07 e52fcc5
Simplifying test code
PratRanj07 94a9df0
target assignment declaration
PratRanj07 55d7f08
Protocol->group_protocol
PratRanj07 80a1e3a
name change
PratRanj07 1d2716e
Changelog added
PratRanj07 dd43a7d
removed test
PratRanj07 5808fc1
Changelog change
PratRanj07 933e813
v2.10.0rc3 release changes (#1969)
pranavrth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3857,7 +3857,9 @@ static PyObject *Admin_c_MemberDescription_to_py(const rd_kafka_MemberDescriptio | |
PyObject *args = NULL; | ||
PyObject *kwargs = NULL; | ||
PyObject *assignment = NULL; | ||
PyObject *target_assignment = NULL; | ||
const rd_kafka_MemberAssignment_t *c_assignment; | ||
const rd_kafka_MemberAssignment_t *c_target_assignment; | ||
|
||
MemberDescription_type = cfl_PyObject_lookup("confluent_kafka.admin", | ||
"MemberDescription"); | ||
|
@@ -3892,6 +3894,15 @@ static PyObject *Admin_c_MemberDescription_to_py(const rd_kafka_MemberDescriptio | |
|
||
PyDict_SetItemString(kwargs, "assignment", assignment); | ||
|
||
c_target_assignment = rd_kafka_MemberDescription_target_assignment(c_member); | ||
if(c_target_assignment) { | ||
target_assignment = Admin_c_MemberAssignment_to_py(c_target_assignment); | ||
if (!target_assignment) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check NULL case is working or not. target_assignment should be None in that case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes it is working |
||
goto err; | ||
} | ||
PyDict_SetItemString(kwargs, "target_assignment", target_assignment); | ||
} | ||
|
||
args = PyTuple_New(0); | ||
|
||
member = PyObject_Call(MemberDescription_type, args, kwargs); | ||
|
@@ -3900,6 +3911,7 @@ static PyObject *Admin_c_MemberDescription_to_py(const rd_kafka_MemberDescriptio | |
Py_DECREF(kwargs); | ||
Py_DECREF(MemberDescription_type); | ||
Py_DECREF(assignment); | ||
Py_XDECREF(target_assignment); | ||
return member; | ||
|
||
err: | ||
|
@@ -3908,6 +3920,7 @@ static PyObject *Admin_c_MemberDescription_to_py(const rd_kafka_MemberDescriptio | |
Py_XDECREF(kwargs); | ||
Py_XDECREF(MemberDescription_type); | ||
Py_XDECREF(assignment); | ||
Py_XDECREF(target_assignment); | ||
Py_XDECREF(member); | ||
return NULL; | ||
} | ||
|
@@ -4003,6 +4016,8 @@ static PyObject *Admin_c_ConsumerGroupDescription_to_py( | |
|
||
cfl_PyDict_SetInt(kwargs, "state", rd_kafka_ConsumerGroupDescription_state(c_consumer_group_description)); | ||
|
||
cfl_PyDict_SetInt(kwargs, "type", rd_kafka_ConsumerGroupDescription_type(c_consumer_group_description)); | ||
|
||
args = PyTuple_New(0); | ||
|
||
consumer_group_description = PyObject_Call(ConsumerGroupDescription_type, args, kwargs); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.