Improved onboarding flow based on blog spot #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-cat
reviewed
Aug 29, 2024
| @@ -279,7 +284,12 @@ void UConfigCatSubsystem::Initialize(FSubsystemCollectionBase& Collection) | |||
| const UConfigCatSettings* ConfigCatSettings = GetDefault<UConfigCatSettings>(); | |||
| if (!ConfigCatSettings || ConfigCatSettings->SdkKey.IsEmpty()) | |||
| { | |||
| UE_LOG(LogConfigCat, Warning, TEXT("Empty SdkKey detected. Please set your SdkKey in the Project Settings.")); | |||
| if(GEngine) | |||
There was a problem hiding this comment.
Suggested change
| if(GEngine) | |
| if (GEngine) |
There was a problem hiding this comment.
I ran the formatter now and uncovered more of these cases, they are now all part of this PR
kp-cat
reviewed
Aug 29, 2024
| { | ||
| return true; | ||
| } | ||
|
|
||
| UE_LOG(LogConfigCat, Warning, TEXT("Trying to access the ConfigCatClient before initialization or after shutdown.")); | ||
| UE_LOG(LogConfigCat, Error, TEXT("Trying to access the ConfigCatClient before initialization or after shutdown.")); |
There was a problem hiding this comment.
Could you please move the error message into a variable to avoid string duplication?
There was a problem hiding this comment.
It's refactored now into a PrintError function for both cases.
kp-cat
reviewed
Aug 29, 2024
| UE_LOG(LogConfigCat, Warning, TEXT("Empty SdkKey detected. Please set your SdkKey in the Project Settings.")); | ||
| if(GEngine) | ||
| { | ||
| GEngine->AddOnScreenDebugMessage(-1, 5.0f, FColor::Red, TEXT("ConfigCat SdkKey missing. Please set your SdkKey in the Project Settings.")); |
There was a problem hiding this comment.
Could you please move the error message into a variable to avoid string duplication?
There was a problem hiding this comment.
It's refactored now into a PrintError function for both cases.
kp-cat
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
ensurewith logs & prints to ensure the process does not hang