Skip to content

Commit

Permalink
log no_match case + log feature flag evaluation on info level
Browse files Browse the repository at this point in the history
  • Loading branch information
kp-cat committed Jul 12, 2022
1 parent db2ddc1 commit 9e42a66
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions lib/config_cat/rollout.ex
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ defmodule ConfigCat.Rollout do
{:halt, {value, variation}}

{:ok, false} ->
log_no_match(comparison_attribute, user_value, comparator, comparison_value)
{:cont, default}

{:error, error} ->
Expand Down Expand Up @@ -138,23 +139,23 @@ defmodule ConfigCat.Rollout do

defp base_value(setting_descriptor, default_value) do
result = Map.get(setting_descriptor, Constants.value(), default_value)
Logger.debug("Returning #{result}")
Logger.info("Returning #{result}")

result
end

defp log_evaluating(key) do
Logger.debug("Evaluating get_value('#{key}').")
Logger.info("Evaluating get_value('#{key}').")
end

defp log_match(comparison_attribute, user_value, comparator, comparison_value, value) do
Logger.debug(
Logger.info(
"Evaluating rule: [#{comparison_attribute}:#{user_value}] [#{Comparator.description(comparator)}] [#{comparison_value}] => match, returning: #{value}"
)
end

defp log_no_match(comparison_attribute, user_value, comparator, comparison_value) do
Logger.debug(
Logger.info(
"Evaluating rule: [#{comparison_attribute}:#{user_value}] [#{Comparator.description(comparator)}] [#{comparison_value}] => no match"
)
end
Expand All @@ -172,7 +173,7 @@ defmodule ConfigCat.Rollout do
end

defp log_valid_user(user) do
Logger.debug("User object: #{inspect(user)}")
Logger.info("User object: #{inspect(user)}")
end

defp log_nil_user(key) do
Expand Down

0 comments on commit 9e42a66

Please sign in to comment.