Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto put auth headers into CORS allowed headers #14

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

z4kn4fein
Copy link
Member

@z4kn4fein z4kn4fein commented Nov 10, 2023

Describe the purpose of your pull request

Headers listed in auth_headers option are now put into the CORS Access-Control-Allow-Headers header.
Similarly, headers listed in headers option are now put into the CORS Access-Control-Expose-Headers.

Related issues (only if applicable)

n/a

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@z4kn4fein z4kn4fein requested a review from a team as a code owner November 10, 2023 18:22
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.1% 62.1% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@z4kn4fein z4kn4fein merged commit 8b7d63b into main Nov 10, 2023
3 of 4 checks passed
@z4kn4fein z4kn4fein deleted the fix-cors-allow-headers branch November 10, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants