Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor mistakes #89

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Fix minor mistakes #89

merged 3 commits into from
Jul 26, 2023

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Jul 25, 2023

Describe the purpose of your pull request

Corrects a few minor mistakes.

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner July 25, 2023 15:17
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.27% ⚠️

Comparison is base (24a36ab) 92.24% compared to head (c60b954) 91.97%.

❗ Current head c60b954 differs from pull request most recent head 99a0804. Consider uploading reports for the commit 99a0804 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   92.24%   91.97%   -0.27%     
==========================================
  Files          18       18              
  Lines        1496     1496              
  Branches      380      378       -2     
==========================================
- Hits         1380     1376       -4     
- Misses        115      119       +4     
  Partials        1        1              
Files Changed Coverage Δ
src/ProjectConfig.ts 97.24% <ø> (ø)
src/ConfigCatClient.ts 89.37% <81.81%> (-1.47%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adams85 adams85 merged commit d91e704 into master Jul 26, 2023
13 checks passed
@adams85 adams85 deleted the fix/minor-mistakes branch July 26, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants