WIP - blueprints after generic_input_renderer #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks useful. Which test is failing? |
…ned after blueprints based in ``generic_input_renderer``.
thet
force-pushed
the
thet-bpinputrenderer
branch
from
79f0398
to
637b4f1
Compare
…mmon or full generic input renderer are used.
rnixx
reviewed
May 9, 2017
| rendered = rendered + (data.rendered or u'') | ||
| else: | ||
| rendered = (data.rendered or u'') + rendered | ||
| return rendered |
There was a problem hiding this comment.
input_generic_renderer is supposed only to render an input tag, no matter whether data already contains rendered markup, please revert
rnixx
reviewed
May 9, 2017
| @@ -333,7 +363,7 @@ def display_proxy_renderer(widget, data): | |||
| input_attrs = input_attributes_full(widget, data, value=val) | |||
| rendered += data.tag('input', **input_attrs) | |||
| else: | |||
| rendered += input_generic_renderer(widget, data) | |||
| rendered = input_generic_renderer(widget, data, pos='after') | |||
There was a problem hiding this comment.
See above, if position really needs to be set here hardcoded (for what exactly?) it should be done here, otherwise revert please
rnixx
reviewed
May 9, 2017
| 'inner-before'= <newtag>message rendered</newtag> | ||
| 'inner-after'= <newtag>rendered message</newtag> | ||
| """ | ||
| rendered = rendered or u'' |
There was a problem hiding this comment.
is it possible that rendered is something other than string here?
There was a problem hiding this comment.
IIRC, rendered can also be UNSET
rnixx
reviewed
May 9, 2017
| @managedprops('min', 'max', 'step', *managed_props__input_full) | ||
| def number_edit_renderer(widget, data): | ||
| return input_generic_renderer(widget, data) | ||
|
|
There was a problem hiding this comment.
No need for dedicated number_edit_renderer. min max and step managed props are defined for number_extractor, and managed props gets aggregated
rnixx
reviewed
May 9, 2017
| @@ -484,9 +514,6 @@ def text_edit_renderer(widget, data): | |||
| factory.defaults['text.class'] = 'text' | |||
|
|
|||
| factory.defaults['text.disabled'] = False | |||
| factory.doc['props']['text.disabled'] = """\ | |||
| Flag input field is disabled. | |||
| """ | |||
rnixx
reviewed
May 9, 2017
| @@ -448,8 +479,7 @@ def tag_renderer(widget, data): | |||
| # text | |||
| ############################################################################### | |||
|
|
|||
| @managedprops('data', 'title', 'size', 'disabled', 'autofocus', | |||
| 'placeholder', 'autocomplete', *css_managed_props) | |||
| @managedprops(*managed_props__input_full) | |||
rnixx
reviewed
May 9, 2017
| @@ -856,8 +883,7 @@ def _pwd_value(widget, data): | |||
| return attr_value('default', widget, data) | |||
|
|
|||
|
|
|||
| @managedprops('data', 'title', 'size', 'disabled', 'autofocus', | |||
| 'placeholder', 'autocomplete', *css_managed_props) | |||
| @managedprops(*managed_props__input_common) | |||
rnixx
reviewed
May 9, 2017
| @@ -958,8 +984,7 @@ def checkbox_extractor(widget, data): | |||
| ) | |||
|
|
|||
|
|
|||
| @managedprops('data', 'title', 'size', 'disabled', 'autofocus', | |||
| 'format', 'disabled', 'checked', *css_managed_props) | |||
| @managedprops('format', *managed_props__input_common) | |||
rnixx
reviewed
May 9, 2017
| @@ -1051,9 +1076,6 @@ def checkbox_display_renderer(widget, data): | |||
| factory.defaults['checkbox.class'] = 'checkbox' | |||
|
|
|||
| factory.defaults['checkbox.disabled'] = False | |||
| factory.doc['props']['checkbox.disabled'] = """\ | |||
| Flag whether checkbox is disabled. | |||
| """ | |||
rnixx
reviewed
May 9, 2017
| @@ -1435,8 +1457,7 @@ def file_extractor(widget, data): | |||
| return value | |||
|
|
|||
|
|
|||
| @managedprops('accept', 'placeholder', 'autofocus', | |||
| 'required', *css_managed_props) | |||
| @managedprops('accept', *managed_props__input_common) | |||
rnixx
reviewed
May 9, 2017
| @managedprops('label', 'class', 'action', 'handler', | ||
| 'next', 'skip', 'expression') | ||
| @managedprops('label', 'action', 'handler', 'next', 'skip', 'expression', | ||
| *managed_props__input_common) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a blueprint chain with a factory, allow blueprints defined after blueprints based in
generic_input_renderer.Work in progress, because there is a failing test.