Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for py-rattler MatchSpec channel parsing #870

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

cisaacstern
Copy link
Contributor

Description

Tests for MatchSpec channel parsing as requested in #869 (comment).

Contrary to the observations in #869, both of these tests pass for me locally when running

$ cd py-rattler
$ pixi run --manifest-path pixi.toml -e test test

Which perhaps means the url parsing regressing is solved in the current main, but broken in the 0.6.3. release?

@cisaacstern cisaacstern changed the title Add tests for py-rattler MatchSpec channel parsing test: Add tests for py-rattler MatchSpec channel parsing Sep 20, 2024
@cisaacstern cisaacstern changed the title test: Add tests for py-rattler MatchSpec channel parsing test: add tests for py-rattler MatchSpec channel parsing Sep 20, 2024
@baszalmstra
Copy link
Collaborator

These have indeed been fixed, but we have to cut a new release. Ill try to do that today.

@baszalmstra baszalmstra merged commit 4ffc20b into conda:main Sep 23, 2024
3 checks passed
@baszalmstra
Copy link
Collaborator

I just released 0.7.0 which should include all these fixes.

@cisaacstern
Copy link
Contributor Author

Thank you so much for the prompt fix!

I just released 0.7.0 which should include all these fixes.

Am I correct in guessing that this release will become available on conda-forge following merge of #878 ?

@wolfv
Copy link
Contributor

wolfv commented Sep 23, 2024

Not quite - it will be on conda-forge once this is built and uploaded, and propagated through the CDN: https://github.com/conda-forge/py-rattler-feedstock

In ~1 hour or so it should be ready! :)

@cisaacstern
Copy link
Contributor Author

Thanks so much for the clarification and prompt turnaround!

I hope to contribute more as I get up to speed on this ecosystem, I am a huge fan 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants