Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip default value for Windows' quicklaunch and deprecate it #272

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Flip default value for Windows' quicklaunch and deprecate it #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a95fc6
Flip default value for Windows' `quicklaunch`
jaimergp Nov 7, 2024
adad330
deprecate quicklaunch
jaimergp Nov 7, 2024
6002900
add news
jaimergp Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions menuinst/_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ class Windows(BasePlatformSpecific):

desktop: Optional[bool] = True
"Whether to create a desktop icon in addition to the Start Menu item."
quicklaunch: Optional[bool] = True
"Whether to create a quick launch icon in addition to the Start Menu item."
quicklaunch: Optional[bool] = False
"DEPRECATED. Whether to create a quick launch icon in addition to the Start Menu item."
terminal_profile: constr(min_length=1) = None
"""
Name of the Windows Terminal profile to create.
Expand Down
2 changes: 1 addition & 1 deletion menuinst/data/menuinst.default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
},
"win": {
"desktop": true,
"quicklaunch": true,
"quicklaunch": false,
"terminal_profile": null,
"url_protocols": null,
"file_extensions": null,
Expand Down
2 changes: 1 addition & 1 deletion menuinst/data/menuinst.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@
},
"quicklaunch": {
"title": "Quicklaunch",
"default": true,
"default": false,
"type": "boolean"
},
"terminal_profile": {
Expand Down
1 change: 1 addition & 0 deletions menuinst/platforms/win.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def _paths(self) -> Tuple[Path, ...]:
if self.metadata["desktop"]:
extra_dirs.append(self.menu.desktop_location)
if self.metadata["quicklaunch"] and self.menu.quick_launch_location:
warnings.warn("Quick launch menus are deprecated.")
extra_dirs.append(self.menu.quick_launch_location)

if extra_dirs:
Expand Down
19 changes: 19 additions & 0 deletions news/272-quicklaunch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* <news item>

### Deprecations

* In v2-style schemas, Windows setting `quicklaunch` default value is now `false` and using it is considered deprecated. (#244 via #272)

### Docs

* <news item>

### Other

* <news item>
Loading