Fix segfaults on Windows while building conda packages (#147)

* debug canaries * delete appkit stuff too on windows * do not fail fast * amend news * revert debugging
conda · Aug 21, 2023 · d60b347 · d60b347
1 parent 40f231e
commit d60b347
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -101,6 +101,7 @@ jobs:
         || endsWith(github.ref_name, '.x')
       )
     strategy:
+      fail-fast: false
       matrix:
         include:
           - runner: ubuntu-latest

diff --git a/news/144-add-canaries b/news/144-add-canaries
@@ -1,6 +1,6 @@
 ### Enhancements
 
-* Add recipe and CI workflow steps to build and upload canaries to `conda-canary`. (#144)
+* Add recipe and CI workflow steps to build and upload canaries to `conda-canary`. (#144, #145)
 
 ### Bug fixes
 

diff --git a/recipe/meta.yaml b/recipe/meta.yaml
@@ -13,6 +13,7 @@ build:
     # Apparently these files make the post-build linkage analysis crash
     # and we should not need them on Windows
     - del /q "{{ SRC_DIR }}\\menuinst\\data\\osx_launcher_*"  # [win]
+    - del /q "{{ SRC_DIR }}\\menuinst\\data\\appkit_launcher_*"  # [win]
     - {{ PYTHON }} -m pip install . -vv
     - copy "%SRC_DIR%\\cwp.py" "%PREFIX%\\"  # [win]