-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework update-news
& banner
into new pre-commit hook (index-blog
)
#234
Draft
kenodegard
wants to merge
11
commits into
conda:main
Choose a base branch
from
kenodegard:index-blog
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for conda-dot-org failed.Built without sensitive environment variables
|
update-news
& banner
into new pre-commit hook (index-blog
)
pre-commit.ci autofix |
ugh pre-commit seems to timeout, need to rethink how the dependencies get installed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently rely on the
npm run update-news
script (written in Python) to scrape the 5 most recent blog posts.We also have a
npm run banners
script to generate banners for blog posts.In this PR we seek to combine all of this into one super tool that scrapes the recent blog posts but also checks the frontmatter for correctness (e.g., is
slug
andimage
defined).In order to avoid complexities (impossibilities?) of trying to call Node.js from Python within the pre-commit container I opted to convert
update-news
into a JS script (now calledindex-blog
).With this change both of the scripts are still callable via
npm run
but they are also included as a pre-commit hook.learn/
orcommunity/
, I have added it to the corresponding_sidebar.json
file.