-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse google calendar react component #176
Conversation
✅ Deploy Preview for conda-dot-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ok so it seems that we need a newer version of react, but that might not work with the current version of docusaurus (2.3.1) used in this project. Is there a reason for using 2.3.1 still, latest version is 3.1.1 it seems After updating to 3.1.1 the following errors still remain
|
f2256de
to
0ecb198
Compare
@goanpeca: I think this fixed the rendering, but we still have that moment.js locale problem. |
f098d1b
to
587dbb8
Compare
@jaimergp I fixed the code to get the API key, but locally and on netlify I now get the following error: Error: Docusaurus server-side rendering could not render static page with path /community/calendar because of error: Cannot read properties of null (reading "registered") I am not sure if it is related to the warnings or if it is something different from the calendar react component :-| |
It is working now as expected 🚀 Got this reply from the docusaurus folks:
|
Awesome, I fixed one issue with the overflow-y of the events (I got a tiny scrollbar with each event item). Unfortunately, I think the library has a bug: conda-forge events show up at 7pm, while conda-community ones show up at 6pm. Yet both happen at the same time every other Wednesday. I think one of the events is set to UTC as the base timezone, while the other is tied to a given timezone with daylight savings. The iframe does show the correct times, but this React component does not... |
Maybe it'd be fixed if we ever get rid of the locale warning? |
Maybe 🤷🏼 Could you locally change this line inside the following file and check if affects anything locally for you (calendar correctly shows the 2 events at the same time)
|
Hmmm. What time zone are you in? I changed mi computer to Berlin, Germany and now events appear as 5:00 pm both 🤔 |
I wonder what else is needed to move this ahead? |
We couldn't fix that 6pm/7pm locale issue so we are currently blocked until that gets fixed. |
for more information, see https://pre-commit.ci
✅ Deploy Preview for conda-dot-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Superseded by #221 |
Description
This PR is changing the iframe google calendar by a styled react component from
https://github.com/ericz1803/react-google-calendar
To better suit the theme.
Before
After
Demo
See
ericz1803/react-google-calendar#68