-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C compiler dep when .xs
files are found.
#4599
Conversation
The pre-commit CI job fails due to |
compiler app for Perl recipes created by conda skeleton.
e894360
to
ea74523
Compare
Although 2014 doesn't make sense, really...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this!
There aren't many people knowledgeable about these things in our community, so I very much appreciate your input. Also, thanks for the detailed description in gh-4598 -- very helpful to properly review this without needing to learn the ins and outs of Perl packaging :).
Sorry it took so long to get this reviewed. Not many/any of us are involved with Perl (packaging), plus conda-skeleton
will likely be deprecated (see gh-4640) which is why it's not high on anyone's (long) ToDo list, I suppose...
That said, the changes are fine and contained to skeleton.cpan
, so I hope this is okay to be merged soon!
I'm glad if I could help. I understand that Perl support does not have a super high priority for people who don't use it themselves. Still, it would be a lot more motivating for further contributions to get feedback a little bit faster, especially for one-line fixes to severe bugs. I still appreciate that you are taking care of this now. Concerning the deprecation of
That would be awesome, thank you! |
@mbargull, happy new year! Are we ready to merge here? Thanks for your support! |
Hey @mbargull, is there anything left to do here except for pushing the merge button? Thanks for your time! |
@mbargull It would be awesome if you could just push that button! Thank you so much! |
@xileF1337 Again, thanks for working on this. As @mbargull alluded to Perl and @mbargull Thanks as always. |
Description
For many Perl modules, a C compiler dependency is not added to
meta.yaml
created byconda skeleton cpan
even though it is required. This is because C files for Perl modules are commonly stored in files with.xs
extension, which are not currently recognized byconda skeleton cpan
. This PR adds detection for the.xs
extension such that the required dependencies are automatically added. This fixes #4598.Checklist - did you ...
news
directory (using the template) for the next release's release notes?