Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check-cla action #204

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Update check-cla action #204

wants to merge 6 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Aug 16, 2024

Description

A few maintenance improvements:

  • converts metadata step (previously JS code) into GitHub Action Expressions
  • converts add signee step (previously JS code) into Python script
  • updates default input values based on upcoming move from conda/infrastructure to conda/cla

Depends on #203

Questions

  • Do we really need to be setting a cla-signed [bot] added once the contributor has signed the CLA label? It's the CLA check status that's actually being used to verify if a contributor has signed the CLA so is the cla-signed [bot] added once the contributor has signed the CLA label just noise?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 16, 2024
@kenodegard kenodegard changed the title Update check-cla Update check-cla action Aug 16, 2024
Comment on lines 136 to 139
> You may have previously signed the conda CLA. That signature is still valid
> for any prior contributions however conda is now a NumFOCUS project and hence
> requires new CLAs to be signed for any new contributions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> You may have previously signed the conda CLA. That signature is still valid
> for any prior contributions however conda is now a NumFOCUS project and hence
> requires new CLAs to be signed for any new contributions.
> You may have previously signed the conda CLA. That signature is still valid
> for any prior contributions however conda is now a fiscally sponsored
> project by NumFOCUS and hence requires new CLAs to be signed for any
> new contributions.

Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Sometimes the login is a bot account that has the `[bot]` suffix. The brackets causes issues for branch names so using the raw user ID (and integer) is better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏗️ In Progress
Development

Successfully merging this pull request may close these issues.

3 participants