-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update check-cla
action
#204
Draft
kenodegard
wants to merge
6
commits into
main
Choose a base branch
from
check-cla
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
[bot] added once the contributor has signed the CLA
label
Aug 16, 2024
jezdez
reviewed
Aug 20, 2024
check-cla/action.yml
Outdated
Comment on lines
136
to
139
> You may have previously signed the conda CLA. That signature is still valid | ||
> for any prior contributions however conda is now a NumFOCUS project and hence | ||
> requires new CLAs to be signed for any new contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
> You may have previously signed the conda CLA. That signature is still valid | |
> for any prior contributions however conda is now a NumFOCUS project and hence | |
> requires new CLAs to be signed for any new contributions. | |
> You may have previously signed the conda CLA. That signature is still valid | |
> for any prior contributions however conda is now a fiscally sponsored | |
> project by NumFOCUS and hence requires new CLAs to be signed for any | |
> new contributions. |
jezdez
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
kenodegard
force-pushed
the
check-cla
branch
from
September 9, 2024 22:05
41833f3
to
e6ccfb7
Compare
kenodegard
force-pushed
the
check-cla
branch
from
September 9, 2024 22:08
e6ccfb7
to
ad3f3c5
Compare
Sometimes the login is a bot account that has the `[bot]` suffix. The brackets causes issues for branch names so using the raw user ID (and integer) is better.
kenodegard
force-pushed
the
check-cla
branch
from
September 10, 2024 03:04
c6e024e
to
534a261
Compare
kenodegard
force-pushed
the
check-cla
branch
from
September 10, 2024 03:05
534a261
to
41d7ce6
Compare
kenodegard
force-pushed
the
check-cla
branch
from
September 10, 2024 03:12
3b82de5
to
bae31a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few maintenance improvements:
Depends on #203
Questions