Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set traitlets application version #981

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Nov 14, 2024

Fixes ##977

Description

This pr set's up the traitlets application to know the current version of conda-store. Setting the version property of a traitlets Application will allow the built in trailtlets '--version' flag to work properly.

For example, running conda-store-server --version now works properly

 $ conda-store-server --version 
2024.11.1
 $ conda-store-worker --version
2024.11.1

ref:
https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L872
https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L200

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Setting the version property of a traitlets Application will allow
the built in trailtlets '--version' flag to work properly.

ref:
  https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L872
  https://github.com/ipython/traitlets/blob/main/traitlets/config/application.py#L200
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for conda-store canceled.

Name Link
🔨 Latest commit a0e87f9
🔍 Latest deploy log https://app.netlify.com/sites/conda-store/deploys/67364f32c497b000084ed33b

@soapy1 soapy1 added needs: review 👀 area: user experience 👩🏻‍💻 Items impacting the end-user experience labels Nov 14, 2024
@soapy1 soapy1 requested a review from trallard November 14, 2024 19:28
@soapy1
Copy link
Contributor Author

soapy1 commented Nov 14, 2024

The Build and maybe upload PyPI package /... is currently a little broken, but fixed in this pr . Will rebase this pr to pick up the fix once #983 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

1 participant